Algorithmize the ImageData constructor #3536
Conversation
There was a problem hiding this comment.
This LGTM. I have left review comments on optional cleanups you could perform while in the area, but feel free to say you're not interested. This is a straightforward refactoring of a dense paragraph into distinct steps and that's unambiguously a good idea, regardless of whether further modernization gets performed.
| nonzero, then return the new <code>ImageData</code> object. If one or both of <var>sw</var> and | ||
| <var>sh</var> are zero, then the constructor must throw an | ||
| <span>"<code>IndexSizeError</code>"</span> <code>DOMException</code> instead.</p> | ||
| numeric arguments <var>sw</var> and <var>sh</var>, it must run these steps:</p> |
There was a problem hiding this comment.
New style is <code ...>ImageData(<var>sw</var>, <var>sh</var>)</code>
There was a problem hiding this comment.
If you changed that then you also need to change the subsequent paragraph somehow I think.
| <span>"<code>IndexSizeError</code>"</span> <code>DOMException</code>.</p></li> | ||
|
|
||
| <li><p><span>Create an <code>ImageData</code> object</span> with parameter | ||
| <var>pixelsPerRow</var> set to <var>sw</var>, and <var>rows</var> set to <var>sh</var>.</p></li> |
There was a problem hiding this comment.
It'd be ideal to give this a variable name, e.g. "Let imageData be the result of creating..." Then the next two steps could refer to it by that variable name.
It sems like the comma before "and" is unnecessary.
|
If you're willing to merge as-is, please do :) |
/canvas.html ( diff )