Check for transferable detachedness after serializing #3557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since serializing can make a transferable detached, it seems better to throw for that later. This matches Chrome/Safari. Firefox ends up with a detached transferable. Edge crashes. See https://bugs.chromium.org/p/chromium/issues/detail?id=816447 for more context. Tests: ... (should update web-platform-tests/wpt#9672)
annevk
added
normative change
topic: serialize and transfer
needs tests
|
Before updating the tests I'd like agreement on this change. |
domenic
approved these changes
Mar 14, 2018
|
Thanks, also need to add Jeremy's test (and flip the conditions of some of the other ones in that PR). |
annevk
added a commit
to web-platform-tests/wpt
that referenced
this pull request
Mar 21, 2018
annevk
removed
the
needs tests
|
FYI: browser bugs are linked from the test PR. |
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Apr 15, 2018
…tonly Automatic update from web-platform-testsTest postMessage() exception order For whatwg/html#3508 and whatwg/html#3557. wpt-commits: fc04bb5708878ee7b68996f8a161507022e07777 wpt-pr: 9672 wpt-commits: fc04bb5708878ee7b68996f8a161507022e07777 wpt-pr: 9672
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Oct 2, 2019
…tonly Automatic update from web-platform-testsTest postMessage() exception order For whatwg/html#3508 and whatwg/html#3557. wpt-commits: fc04bb5708878ee7b68996f8a161507022e07777 wpt-pr: 9672 wpt-commits: fc04bb5708878ee7b68996f8a161507022e07777 wpt-pr: 9672 UltraBlame original commit: 7aa5cbfd0daa25162b40ca204419fa9fe82049a6
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Oct 2, 2019
…tonly Automatic update from web-platform-testsTest postMessage() exception order For whatwg/html#3508 and whatwg/html#3557. wpt-commits: fc04bb5708878ee7b68996f8a161507022e07777 wpt-pr: 9672 wpt-commits: fc04bb5708878ee7b68996f8a161507022e07777 wpt-pr: 9672 UltraBlame original commit: 7aa5cbfd0daa25162b40ca204419fa9fe82049a6
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Oct 2, 2019
…tonly Automatic update from web-platform-testsTest postMessage() exception order For whatwg/html#3508 and whatwg/html#3557. wpt-commits: fc04bb5708878ee7b68996f8a161507022e07777 wpt-pr: 9672 wpt-commits: fc04bb5708878ee7b68996f8a161507022e07777 wpt-pr: 9672 UltraBlame original commit: 7aa5cbfd0daa25162b40ca204419fa9fe82049a6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since serializing can make a transferable detached, it seems better to throw for that later.
This matches Chrome/Safari. Firefox ends up with a detached transferable. Edge crashes.
See https://bugs.chromium.org/p/chromium/issues/detail?id=816447 for more context.
Tests: ... (should update web-platform-tests/wpt#9672)
/acknowledgements.html ( diff )
/structured-data.html ( diff )