Export the definition of CORS-same-origin #3605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
annevk
reviewed
Apr 3, 2018
source
Outdated
| @@ -6841,7 +6841,7 @@ a.setAttribute('href', 'https://example.com/'); // change the content attribute | |||
|
|
|||
| <p>A <span data-x="concept-response">response</span> whose <span | |||
| data-x="concept-response-type">type</span> is "<code data-x="">basic</code>", "<code | |||
| data-x="">cors</code>", or "<code data-x="">default</code>" is <dfn>CORS-same-origin</dfn>. <ref | |||
| data-x="">cors</code>", or "<code data-x="">default</code>" is <dfn data-export="">CORS-same-origin</dfn>. <ref | |||
There was a problem hiding this comment.
Thanks for exporting this one! You'll need to add a newline after <dfn and then rewrap the next line. We have a 100 limit for most columns.
|
As a tangent, @annevk, any idea why this lives in HTML instead of Fetch? |
|
No, I think we should refactor how all this works still. |
|
(Well, the reason is that Ian factored it as such at some point to integrate with CORS, when fetch wasn't defined in a standalone specification.) |
This is used by the CSSOM spec, and so should be exported for automatic linking.
csnardi
force-pushed
the
export-cors-same-origin
branch
from
285bbf1
to
08a9aa1
Compare
|
I fixed up the line wrapping, sorry about that! |
annevk
approved these changes
Apr 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is used by the CSSOM spec, and so should be exported for automatic linking.
/acknowledgements.html ( diff )
/urls-and-fetching.html ( diff )