Editorial: fix confusing phrasing for opener setter #3916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdm
reviewed
Aug 14, 2018
source
Outdated
| <code>Window</code> object, "<code data-x="">opener</code>", { [[Value]]: the given value, | ||
| [[Writable]]: true, [[Enumerable]]: true, [[Configurable]]: true }). Rethrow any | ||
| exceptions.</p></li> | ||
| <li><p>Perofrm <span>OrdinaryDefineOwnProperty</span>(this <code>Window</code> object, "<code |
annevk
approved these changes
Aug 15, 2018
|
I think that would be an alternative to "rethrow any exceptions", but we've mostly confined the usage of ?/! notation to larger algorithms which are explicitly called out as interfacing with the ES spec, whereas this is more of a one-off call into those mechanisms. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3904.
/browsers.html ( diff )