More HTML decoding

[edent]

Re #3683

Would it be better if I did each of these commits as a separate PR? There will be quite a lot of them.

---

/acknowledgements.html ( diff )
/embedded-content-other.html ( diff )
/form-elements.html ( diff )
/images.html ( diff )
/text-level-semantics.html ( diff )

[zcorpan]

Why did you remove the data-x?

[edent]

My beautifier identified it as empty when I cleaned that link. Is data-x used for something specific when building the document?

[zcorpan]

Yes, it's for cross-references, so in this case it's explicitly marking the span as not being a cross-reference.

[annevk]

I think grouping them is fine, but some might need some discussion. E.g., −1 is hard to distinguish from -1 so I'm not sure if we should do that as it might lead to folks using -1 instead. (I've used − in other standards for this reason.)

[edent]

What's the risk of someone using -1 rather than −1?

Would it be better to use text like "negative 1" or "minus 1"?

Happy to make the change.

[annevk]

I'm mainly worried about introducing inconsistencies in formatting. I don't think switching to text helps as we also format equations with this character. Keeping the existing entity or switching it to − seems good to me.

[edent]

@annevk ok - reverted to −

@zcorpan ok - reverted the data-x=""

Let me know if this PR is OK to merge and I'll continue with the rest of the encoded entities.

[annevk]

Thanks, I think this can be merged after rebasing (feel free to force push after fixing). Not entirely clear why it conflicts.

[zcorpan]

I think the conflict is the first commit which is already in master.

[domenic]

I'd prefer to have only one (or I guess two since we did #4139 already) commit for all these changes, to keep the commit log clean. So it'd be ideal to not merge this until the whole spec is converted and merging would close #3683.

Edit: maybe that is already the case?

[domenic]

@edent sorry we dropped this for a while. Do you think this is all the decoding work there is to do? If so, we can take care of the rebasing for you, since it's our fault for letting this sit.

[edent]

@domenic please can you rebase - I'm busy for the next week or so. Then I'll do some more decoding.

[annevk]

Rebased.

[domenic]

Rebased again, and let's merge this :). Sorry again for the delay.

[domenic]

@edent it looks like your affiliation with the alphagov GitHub organization is not public; could you make it so per https://help.github.com/en/articles/publicizing-or-hiding-organization-membership to allow the IPR checker to sign off?

[edent]

@domenic I am no longer a member of @alphagov, although I was when I made the PR.

I am on secondment to @nhsx, which is part of the UK Government. If that helps?

[annevk]

@edent we'd need NHSX to sign the agreement, I think.

Although maybe since the contribution was made while you were at alphagov and were their contact person we can override the bot in this case...

[edent]

Won't be able to get NHSX to sign any time soon, so if you could override the bot that'd be great.