Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalize the description of aborting downloads #4450

Merged
merged 1 commit into from
Apr 11, 2019

Conversation

xyaoinum
Copy link
Contributor

@xyaoinum xyaoinum commented Mar 26, 2019

A user agent can abort a download for a variety of reasons, not necessarily restricted to the cross-origin scenarios.

Also move the potential of blocking a download out of the filename selection algorithm.


/links.html ( diff )

@jkarlin
Copy link

jkarlin commented Apr 4, 2019

This is in regards to WICG/interventions#67

Copy link
Member

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, and seems likely to codify existing behavior in many browsers. @annevk would you mind double-checking, as our resident navigation guru?

Copy link
Member

@annevk annevk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for checking with me, I think we need a different approach here, unless I misunderstood something.

source Show resolved Hide resolved
@annevk
Copy link
Member

annevk commented Apr 10, 2019

Suggested commit message:

Generalize the description of aborting downloads

A user agent can abort a download for a variety of reasons, not necessarily restricted to the cross-origin scenarios.

Also move the potential of blocking a download out of the filename selection algorithm.

Did you want to add your name to the Acknowledgments section? I was about to merge this and noticed you hadn't done that.

A user agent can abort a download for a variety of reasons, not necessarily
restricted to the cross-origin scenarios.

Also move the potential of blocking a download out of the filename selection
algorithm.
@xyaoinum xyaoinum changed the title Generalize the description of aborting download by user agent Generalize the description of aborting downloads Apr 10, 2019
@xyaoinum
Copy link
Contributor Author

Updated the commit message and added my name to Acknowledgments.

@annevk annevk merged commit 8891139 into whatwg:master Apr 11, 2019
@annevk
Copy link
Member

annevk commented Apr 11, 2019

Thanks!

@VIRAT9358

This comment was marked as spam.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

6 participants