-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generalize the description of aborting downloads #4450
Conversation
This is in regards to WICG/interventions#67 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM, and seems likely to codify existing behavior in many browsers. @annevk would you mind double-checking, as our resident navigation guru?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for checking with me, I think we need a different approach here, unless I misunderstood something.
Suggested commit message:
Did you want to add your name to the Acknowledgments section? I was about to merge this and noticed you hadn't done that. |
A user agent can abort a download for a variety of reasons, not necessarily restricted to the cross-origin scenarios. Also move the potential of blocking a download out of the filename selection algorithm.
73cda83
to
656174f
Compare
Updated the commit message and added my name to Acknowledgments. |
Thanks! |
A user agent can abort a download for a variety of reasons, not necessarily restricted to the cross-origin scenarios.
Also move the potential of blocking a download out of the filename selection algorithm.
/links.html ( diff )