Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Specify syntatic mouse event name for click() #4453

Merged
merged 2 commits into from
Mar 28, 2019
Merged

Specify syntatic mouse event name for click() #4453

merged 2 commits into from
Mar 28, 2019

Conversation

CYBAI
Copy link
Contributor

@CYBAI CYBAI commented Mar 27, 2019 •
edited by pr-preview bot
Loading

@domenic
Copy link
Member

domenic commented Mar 27, 2019

Thank you! Would you mind rewrapping those two lines to 100 characters max? You can use https://output.jsbin.com/maferi if you want.

Also, do you want to add your name to the acknowledgements section, per https://github.com/whatwg/html/blob/master/CONTRIBUTING.md#pull-requests ?

@CYBAI
Copy link
Contributor Author

CYBAI commented Mar 28, 2019

@domenic Thanks! Sorry for that I didn't notice we need to wrap the lines to 100 characters. Updated and also added my name to acknowledgement 😄

domenic
domenic approved these changes Mar 28, 2019
View reviewed changes
Copy link
Member

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much!!

@domenic domenic merged commit 6c7c5a7 into whatwg:master Mar 28, 2019
@CYBAI CYBAI deleted the named-click branch March 28, 2019 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@domenic domenic domenic approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CYBAI @domenic