Revert JSON modules #4943
Merged
Revert JSON modules #4943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As explained at WICG/webcomponents#839 the current setup is insecure. This reverts db03474.
|
Perhaps we should take a different approach though as Wasm modules could use much of the infrastructure created here. |
|
It seems clear that JSON modules have lost multi-engine support, so removing from the spec sounds good. I suppose we should also remove the wpt tests. Let's not worry about Wasm modules for now--it will be easy to add this infrastructure back when it's time. |
littledan
approved these changes
Sep 28, 2019
This was referenced Sep 28, 2019
|
Given the security issue we raised, we support removing this from the spec at least for now. |
|
@littledan could you have another look as it seems I missed some things initially. Unfortunately |
annevk
added a commit
to web-platform-tests/wpt
that referenced
this pull request
Oct 1, 2019
See whatwg/html#4943 for context.
|
I've notified the original implementation bugs:
(I also created a PR to mark all WPT tests as tentative.) |
Ms2ger
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Oct 1, 2019
See whatwg/html#4943 for context.
|
I don't quite have the energy to follow up here during TC39. Maybe @Ms2ger could help sooner. |
Ms2ger
approved these changes
Oct 2, 2019
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Oct 14, 2019
…estonly Automatic update from web-platform-tests Mark JSON module tests as tentative See whatwg/html#4943 for context. -- wpt-commits: bec7ffa28cc69fe8d8fb343fd9184d30ecce3070 wpt-pr: 19441 --HG-- rename : testing/web-platform/tests/html/semantics/scripting-1/the-script-element/json-module/invalid-content-type.html => testing/web-platform/tests/html/semantics/scripting-1/the-script-element/json-module/invalid-content-type.tentative.html rename : testing/web-platform/tests/html/semantics/scripting-1/the-script-element/json-module/module.html => testing/web-platform/tests/html/semantics/scripting-1/the-script-element/json-module/module.tentative.html rename : testing/web-platform/tests/html/semantics/scripting-1/the-script-element/json-module/non-object.any.js => testing/web-platform/tests/html/semantics/scripting-1/the-script-element/json-module/non-object.tentative.any.js rename : testing/web-platform/tests/html/semantics/scripting-1/the-script-element/json-module/parse-error.html => testing/web-platform/tests/html/semantics/scripting-1/the-script-element/json-module/parse-error.tentative.html rename : testing/web-platform/tests/html/semantics/scripting-1/the-script-element/json-module/utf8.html => testing/web-platform/tests/html/semantics/scripting-1/the-script-element/json-module/utf8.tentative.html rename : testing/web-platform/tests/html/semantics/scripting-1/the-script-element/json-module/valid-content-type.html => testing/web-platform/tests/html/semantics/scripting-1/the-script-element/json-module/valid-content-type.tentative.html
xeonchen
pushed a commit
to xeonchen/gecko
that referenced
this pull request
Oct 14, 2019
…estonly Automatic update from web-platform-tests Mark JSON module tests as tentative See whatwg/html#4943 for context. -- wpt-commits: bec7ffa28cc69fe8d8fb343fd9184d30ecce3070 wpt-pr: 19441
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Oct 16, 2019
…estonly Automatic update from web-platform-tests Mark JSON module tests as tentative See whatwg/html#4943 for context. -- wpt-commits: bec7ffa28cc69fe8d8fb343fd9184d30ecce3070 wpt-pr: 19441 UltraBlame original commit: 4c1fd5ec1e57a33ef9e732ee1a87420825bfcb0a
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Oct 16, 2019
…estonly Automatic update from web-platform-tests Mark JSON module tests as tentative See whatwg/html#4943 for context. -- wpt-commits: bec7ffa28cc69fe8d8fb343fd9184d30ecce3070 wpt-pr: 19441 UltraBlame original commit: 4c1fd5ec1e57a33ef9e732ee1a87420825bfcb0a
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Oct 16, 2019
…estonly Automatic update from web-platform-tests Mark JSON module tests as tentative See whatwg/html#4943 for context. -- wpt-commits: bec7ffa28cc69fe8d8fb343fd9184d30ecce3070 wpt-pr: 19441 UltraBlame original commit: 4c1fd5ec1e57a33ef9e732ee1a87420825bfcb0a
Closed
1 task
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As explained at WICG/webcomponents#839 the current setup is insecure.
This reverts db03474.
TODO:
cc @littledan @Ms2ger
/infrastructure.html ( diff )
/scripting.html ( diff )
/timers-and-user-prompts.html ( diff )
/webappapis.html ( diff )