Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editorial: clarify which document of a top-level browsing context #5093

Merged
merged 2 commits into from Nov 20, 2019
Merged

Editorial: clarify which document of a top-level browsing context #5093

merged 2 commits into from Nov 20, 2019

Conversation

annevk
Copy link
Member

@annevk annevk commented Nov 18, 2019 •
edited by pr-preview bot

@annevk
Copy link
Member Author

annevk commented Nov 18, 2019

@rakina would you care to review?

@domenic
Copy link
Member

domenic commented Nov 18, 2019

You may want to fix #2523 while you're here.

@domenic domenic added clarification Standard could be clearer topic: focus labels Nov 18, 2019
@annevk
Copy link
Member Author

annevk commented Nov 18, 2019

This particular algorithm can only be invoked for a top-level browsing context. I could make it a variable though and did think of doing that.

@annevk annevk requested a review from domenic November 19, 2019 15:43
rakina
rakina approved these changes Nov 20, 2019
View reviewed changes
Copy link
Member

@rakina rakina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@annevk annevk merged commit 3e1874e into master Nov 20, 2019
@annevk annevk deleted the annevk/focus-tlbc branch November 20, 2019 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@domenic domenic domenic approved these changes

@rakina rakina rakina approved these changes

Assignees
No one assigned
Labels
clarification Standard could be clearer topic: focus
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@annevk @domenic @rakina