Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not report work outside of event loop #5123

Merged
merged 2 commits into from
Dec 4, 2019
Merged

Conversation

npm1
Copy link
Contributor

@npm1 npm1 commented Dec 4, 2019

Fixes w3c/longtasks#77. Reporting work outside of the event loop could leak information such as long GC.

  • At least two implementers are interested (and none opposed):
    • Chrome
    • Firefox
  • Tests are written and can be reviewed and commented upon at:
    • This cannot be tested by WPTs. Only Chrome implements this API at the moment which does not leak this information as far as I can tell.

/webappapis.html ( diff )

@domenic domenic merged commit d5a8e4d into whatwg:master Dec 4, 2019
@npm1 npm1 deleted the longtask branch December 4, 2019 18:54
@annevk
Copy link
Member

annevk commented Dec 5, 2019

This should also have removed "event loop end", no?

@npm1
Copy link
Contributor Author

npm1 commented Dec 5, 2019

I think a variable like that would be needed to split the work within the 'task' in 'spin the event loop'. But it's unused right now, and hopefully the task reentrancy is removed instead, so I can remove this.

@domenic
Copy link
Member

domenic commented Dec 5, 2019

Sorry about missing that in review; I did mentally note to check for dead code, but failed to find it.

@npm1 npm1 mentioned this pull request Dec 5, 2019
annevk pushed a commit that referenced this pull request Dec 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Reporting work outside of event loop can cause leaks
3 participants