Pass sourceText to OrdinaryFunctionCreate for event handlers #5514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
annevk
approved these changes
May 6, 2020
annevk
added
do not merge yet
domenic
added a commit
to web-platform-tests/wpt
that referenced
this pull request
May 7, 2020
domenic
added
topic: events
and removed
do not merge yet
|
This now has tests, which pass in Chrome Canary (not stable) and Firefox. We'll see what the bots say for Safari, and I'll file a bug if necessary. Edit: according to the test bots, Safari does not implement this; filed https://bugs.webkit.org/show_bug.cgi?id=211597. Adding @TimothyGu for an extra review if he has time, to double-check my event target logic. |
domenic
added a commit
to web-platform-tests/wpt
that referenced
this pull request
May 7, 2020
TimothyGu
reviewed
May 8, 2020
|
|
||
| <dd> | ||
| <dl class="switch"> | ||
| <dt>If <var>eventHandler</var> is an <code data-x="handler-onerror">onerror</code> <span |
There was a problem hiding this comment.
I would go a bit further and say 'if name is "onerror" '. The Window check looks good though.
domenic
added a commit
to web-platform-tests/wpt
that referenced
this pull request
May 8, 2020
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
May 15, 2020
…=testonly Automatic update from web-platform-tests Test the sourceText of event handlers Follows whatwg/html#5514. -- wpt-commits: af188628fbb56cbce2ba5c9ca418b5f465a64063 wpt-pr: 23467
xeonchen
pushed a commit
to xeonchen/gecko
that referenced
this pull request
May 15, 2020
…=testonly Automatic update from web-platform-tests Test the sourceText of event handlers Follows whatwg/html#5514. -- wpt-commits: af188628fbb56cbce2ba5c9ca418b5f465a64063 wpt-pr: 23467
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
May 20, 2020
…=testonly Automatic update from web-platform-tests Test the sourceText of event handlers Follows whatwg/html#5514. -- wpt-commits: af188628fbb56cbce2ba5c9ca418b5f465a64063 wpt-pr: 23467
xeonchen
pushed a commit
to xeonchen/gecko
that referenced
this pull request
May 20, 2020
…=testonly Automatic update from web-platform-tests Test the sourceText of event handlers Follows whatwg/html#5514. -- wpt-commits: af188628fbb56cbce2ba5c9ca418b5f465a64063 wpt-pr: 23467
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5500.
(See WHATWG Working Mode: Changes for more details.)
/webappapis.html ( diff )