Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test the sourceText of event handlers #23467

Merged
merged 1 commit into from May 8, 2020
Merged

Conversation

domenic
Copy link
Member

@domenic domenic commented May 7, 2020

Follows whatwg/html#5514.

Note that stable Chrome fails this but Chrome Canary passes this, since https://bugs.chromium.org/p/chromium/issues/detail?id=1077133 was recently fixed.

Copy link
Member

@annevk annevk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also check that these signatures are meaningful somehow or is that already tested elsewhere?

@domenic
Copy link
Member Author

domenic commented May 8, 2020

You mean, check that onerror event handlers actually have access to these 5 variables? Yeah, that's tested in onerroreventhandler.html in the same directory.

Copy link
Member

@annevk annevk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That doesn't seem to have coverage for all these places though, but okay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants