New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Define "relevant settings object" for any platform object, not just global objects. #564
Changes from 3 commits
777623f
99a50d9
a25f6f9
92db03e
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2852,7 +2852,9 @@ a.setAttribute('href', 'http://example.com/'); // change the content attribute d | |
<li><dfn data-noexport="">Supported property names</dfn> | ||
<li><dfn data-noexport="">Unenumerable</dfn> | ||
<li><dfn data-noexport="">Determine the value of a named property</dfn> | ||
<li><dfn data-noexport="" data-x-href="https://heycam.github.io/webidl/#dfn-platform-object">Platform object</dfn></li> | ||
<li><dfn data-noexport="">Platform array objects</dfn> | ||
<li><dfn data-noexport="" data-x-href="https://heycam.github.io/webidl/#es-platform-objects">Global environment associated with</dfn> a platform object</li> | ||
<li><dfn data-noexport="" data-x="dfn-read-only-array">Read only</dfn> (when applied to arrays) | ||
<li><dfn data-noexport="" data-x="dfn-callback-this-value">Callback this value</dfn> | ||
<li><dfn data-noexport="" data-x="concept-idl-convert" data-x-href="https://heycam.github.io/webidl/#es-type-mapping">Converting</dfn> between WebIDL types and JS types | ||
|
@@ -85828,9 +85830,14 @@ interface <dfn>NavigatorOnLine</dfn> { | |
<p>An <span>environment settings object</span>'s <dfn data-x="environment settings object's | ||
Realm">Realm</dfn> is its <span>realm execution context</span>'s Realm component.</p> | ||
|
||
<p>The <dfn>relevant settings object for a global object</dfn> <var>o</var> is the | ||
<span>environment settings object</span> whose <span>global object</span> is <var>o</var>. | ||
(There is always a 1:1 mapping of global objects to environment settings objects.)</p> | ||
<p>The <dfn data-x="relevant settings object for a global object" data-lt="relevant settings | ||
object for a global object"></dfn><dfn>relevant settings object</dfn> for a <span>global | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This seems wrong. How about we put the old There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It turns out that Mixed Content and Secure Contexts already define their own shortcut for "relevant settings object", so omitting the |
||
object</span> <var>o</var> is the <span>environment settings object</span> whose <span>global | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Capitalize Although, I am not sure we use There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yeah, I didn't find an exact precedent, so I've removed the |
||
object</span> is <var>o</var>. The <span>relevant settings object</span> for a non-global | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. No extra indent. One space between sentences. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Done. |
||
<span>platform object</span> <var>o</var> is the <span>environment settings object</span> whose | ||
<span>global object</span> is the global object of the <span>global environment associated | ||
with</span> <var>o</var>. (There is always a 1:1 mapping of global objects to environment settings | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think we should just use the same phrasing as above: There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Done, but I think I like the recursive way better. It's more clear that the steps after getting to a global object are the same. |
||
objects.)</p> | ||
|
||
<p>The <dfn>script corresponding to the running execution context</dfn> is the | ||
<span>script</span> in the [[HostDefined]] slot of the <span>running JavaScript execution | ||
|
@@ -118347,6 +118354,7 @@ INSERT INTERFACES HERE | |
Jeff Cutsinger, | ||
Jeff Schiller, | ||
Jeff Walden, | ||
Jeffrey Yasskin, | ||
Jeffrey Zeldman, | ||
胡慧鋒 (Jennifer Braithwaite), | ||
Jens Bannmann, | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<p>
and</p>
inside<dt>
s and<dd>
s is the prevailing style, I am pretty sure...There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indent one space, not two (here and throughout)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dt
doesn't allowp
:-)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Huh, seems like it does... But didn't before. Anyway
source
doesn't contain<dt><p>
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove trailing comma in the
dt
sThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed the indent; removed the
<dl>
entirely per a subsequent comment.