Define "relevant settings object" for any platform object, not just global objects. #564
Conversation
| (There is always a 1:1 mapping of global objects to environment settings objects.)</p> | ||
| <p>The <dfn>relevant settings object</dfn> for a <span>platform object</span> <var>o</var> is:</p> | ||
| <dl class="switch"> | ||
| <dt>If <var>o</var> is a global object,</dt> |
There was a problem hiding this comment.
<p> and </p> inside <dt>s and <dd>s is the prevailing style, I am pretty sure...
There was a problem hiding this comment.
Indent one space, not two (here and throughout)
There was a problem hiding this comment.
Huh, seems like it does... But didn't before. Anyway source doesn't contain <dt><p>.
There was a problem hiding this comment.
Remove trailing comma in the dts
There was a problem hiding this comment.
Fixed the indent; removed the <dl> entirely per a subsequent comment.
|
I haven't run the build yet, but it seems like changing the |
| <var>o</var>. (There is always a 1:1 mapping of global objects to environment settings | ||
| objects.)</dd> | ||
| <dt>Otherwise,</dt> | ||
| <dd>the <span>relevant settings object</span> for the global object of the <span>global |
There was a problem hiding this comment.
I think we should just use the same phrasing as above: ... whose <span>global object</span> is the ...
There was a problem hiding this comment.
Done, but I think I like the recursive way better. It's more clear that the steps after getting to a global object are the same.
…cursive definition.
|
@domenic, there are no uses of "relevant settings object" in HTML. I think the only uses are https://w3c.github.io/webappsec-secure-contexts/#framework and https://w3c.github.io/webappsec-mixed-content/#categorize-settings-object. (@mikewest) @tabatkins Can Shepherd find all uses of a particular term? |
|
Ah OK. In that case this LGTM, although I still haven't run the build (we really should get the CI set up...). @annevk, want to sign off too? |
|
Yeah, I think this is alright. This term was added as a hook for XMLHttpRequest. So I guess we'd have to update the links everywhere or keep the old ID working. |
|
I can also squash and/or rebase when you're ready. Updating the links I've found will generally make them shorter and simpler, but I can also add the extra |
|
You can put an |
This does not work. The only thing that works is to add an empty span with an id nearby. I have tried this repeatedly. |
|
Euhm, search for e.g., |
|
The way |
| <span>environment settings object</span> whose <span>global object</span> is <var>o</var>. | ||
| (There is always a 1:1 mapping of global objects to environment settings objects.)</p> | ||
| <p>The <dfn data-x="relevant settings object for a global object" data-lt="relevant settings | ||
| object for a global object"></dfn><dfn>relevant settings object</dfn> for a <span>global |
There was a problem hiding this comment.
This seems wrong. How about we put the old id on the <p> given that you want both?
There was a problem hiding this comment.
It turns out that Mixed Content and Secure Contexts already define their own shortcut for "relevant settings object", so omitting the data-lt won't break their builds. It probably will break https://github.com/whatwg/xhr/blob/master/Overview.src.html#L283. Done anyway.
…l-object working, instead of the full <dfn> to keep source compatibility.
|
Thank you, landed as 25eaf88. |
This grounds lookups like the ones in https://webbluetoothcg.github.io/web-bluetooth/#notification-events and https://webbluetoothcg.github.io/web-bluetooth/#service-change-events where I'm trying to get an event loop for an object.
Apologies if I've gotten any markup wrong.