Update CustomElementsRegistry whenDefined to resolve to Class #5831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #5552. As per issue discussion, the currently specified behavior is to resolve with undefined, which requires an extra step if the user want to extend the custom element by calling customElements.get() to get the element constructor first. Updated tests on web-platform-tests/wpt#25030
|
This seems equivalent to #5833. I'll leave feedback there. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5552.
As per issue discussion, the currently specified behavior is to resolve with undefined, which requires an extra step if the user want to extend the custom element by calling customElements.get() to get the element constructor first.
(See WHATWG Working Mode: Changes for more details.)
/custom-elements.html ( diff )