Issue #5552 - Update whenDefined steps to resolve with the class

[WebReflection]

Fixes #5552

• At least two implementers are interested (and none opposed):
  • @rniwa
  • @ExE-Boss
• Tests are written and can be reviewed and commented upon at:
  • Issue #5552 - Verify a defined class is resolved whenDefined web-platform-tests/wpt#25033
• Implementation bugs are filed:
  • Chrome: https://bugs.chromium.org/p/chromium/issues/detail?id=1116970
  • Firefox: https://bugzilla.mozilla.org/show_bug.cgi?id=1659410
  • Safari: https://bugs.webkit.org/show_bug.cgi?id=215562

---

/custom-elements.html ( diff )

[ExE-Boss]

I’m pretty sure that “implementers” refers to browser engines and other implementations of the HTML specification.

[annevk]

This seems equivalent to #5831.

Equivalent to get(name), you want to resolve with the entry's constructor (and xref it).

[ExE-Boss]

You also need to update the define steps above:

https://github.com/whatwg/html/blob/92601766919431dad494060bb70adc156b15c7e0/source#L66336-L66348

[WebReflection]

This seems equivalent to #5831.

Except it has all bugs attached ... maybe we can flag that one as duplicated, or move all filed bugs in there? Filed bugs also point at this URL ... didn't notice there was already a PR

[annevk]

I also noticed that whenDefined() doesn't seem to return promise at the moment, but perhaps that's best tackled separately.

[rniwa]

WebKit patch is ready to go: https://bugs.webkit.org/show_bug.cgi?id=215562

[annevk]

@mfreed7 @smaug---- @EdgarChen @domenic thoughts? Seems reasonable to me.

@WebReflection you'll have to sign https://participate.whatwg.org/agreement.

[WebReflection]

@WebReflection you'll have to sign https://participate.whatwg.org/agreement.

Done 👍

[ExE-Boss]

This should probably also have “Fixes #5552” in the PR description.

---

See GitHub Docs for details.

[EdgarChen]

@mfreed7 @smaug---- @EdgarChen @domenic thoughts? Seems reasonable to me.

This seems reasonable to me.

[annevk]

@WebReflection given https://whatwg.org/ipr-policy#210-field-of-web-technologies I think we need your employer to sign the agreement as ad blocking does seem to be in that realm.

Other than that I think we're good to go here with agreement from two implementers (as well as a patch), tests, and a reviewed PR.

[WebReflection]

@annevk I’m not contributing on behalf of my employer here, I’m even on vacation right now, and this is my own account, not the one used for my work.

Do I need to ask them? Looks like friction for no reason, and this contribution has nothing to do with ads.

Please let me know, thanks.

[annevk]

I checked and I think all is in order. I did notice that IDL wasn't updated and I pushed a commit for that. At this point I should let @domenic do the final review though.

[rniwa]

This PR has been implemented in WebKit as of https://trac.webkit.org/r266142.

[domenic]

Should update the domintro too.

Marking as "Request changes" as @WebReflection definitely works in the field of web technologies, and as such needs their employer to sign the agreement.

[emilio]

I have a patch for Gecko in https://phabricator.services.mozilla.com/D88281 too fwiw, but I want to wait till WPT and the spec are updated.

[WebReflection]

Just FYI, I've contacted my company about this but many, me included, are on vacation these days, so this might take a while.

Should update the domintro too.

@domenic anything I should do? Not sure I even know what that is, thanks.

[annevk]

@WebReflection basically

   <dt><var>window</var> . <code data-x="dom-window-customElements">customElements</code> . <code
   subdfn data-x="dom-CustomElementRegistry-whenDefined">whenDefined</code>(<var>name</var>)</dt>

   <dd>Returns a promise that will be fulfilled when a <span>custom element</span> becomes defined
   with the given name. (If such a <span>custom element</span> is already defined, the returned
   promise will be immediately fulfilled.) Returns a promise rejected with a
   <span>"<code>SyntaxError</code>"</span> <code>DOMException</code> if not given a <span>valid
   custom element name</span>.</dd>

needs updating to account for the fact that the promise has a specific fulfillment value. "domintro" are the green boxes you sometimes see in WHATWG standards that have a more developer-facing informal description of an API.

[WebReflection]

basically ...

Done 👍

[WebReflection]

Marking as "Request changes" as @WebReflection definitely works in the field of web technologies, and as such needs their employer to sign the agreement.

I've just submitted the agreement on behalf of the company I work for, I hope everything is fine now.

[annevk]

@WebReflection you'll need to make your membership of eyeo-gmbh public.

[WebReflection]

@annevk you mean the org, right? I'm on it 👍

[annevk]

@WebReflection I realize, but https://docs.github.com/en/github/setting-up-and-managing-your-github-user-account/publicizing-or-hiding-organization-membership is important as our bot can't see that otherwise.

[WebReflection]

@annevk I should be in the list now https://github.com/eyeo-gmbh ... anything else I should do/ask for? Thanks!

Edit I should have eyeo in the list of my orgs now

[annevk]

When I go to your profile I don't see it.

[annevk]

Also, it seems you undid my changes to this branch so the IDL is no longer correct.

[WebReflection]

When I go to your profile I don't see it.

can you please try again? it had private visibility, but I've thought bots would see it regardless. Anyway, it's public now.

Also, it seems you undid my changes to this branch so the IDL is no longer correct.

which change? happy to put it back.

[WebReflection]

@annevk I've rebased from upstream too, but I'm afraid I'm not sure what/where is the change you are mentioning. Any hint appreciated, thanks.

[ExE-Boss]

@WebReflection
You need to change the return type of the WebIDL definition of CustomElementRegistry.whenDefined(…) from Promise<undefined> to Promise<CustomElementConstructor>.

[WebReflection]

@WebReflection
You need to change the return type of the WebIDL definition

done

It's been addressed.

[annevk]

Thanks @WebReflection!

[WebReflection]

Thanks @WebReflection!

no, thank you all for this, it looks tiny, but I believe it improves a lot usability 🎉