Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix WebIDL terms #6278

Merged
merged 4 commits into from
Jan 25, 2021
Merged

Fix WebIDL terms #6278

merged 4 commits into from
Jan 25, 2021

Conversation

momdo
Copy link
Contributor

@momdo momdo commented Jan 9, 2021

@domenic
Copy link
Member

domenic commented Jan 11, 2021

Thanks! However, as you can see from the build error, we need to replace idl-Error.

It seems to appear in

   <li><p>Let <var>errorValue</var> be the value that represents the error: in the case of an
   uncaught exception, that would be the value that was thrown; in the case of a JavaScript error
   that would be an <code data-x="idl-Error">Error</code> object. If there is no corresponding
   value, then the null value must be used instead.</p></li>

which is a known-confusing section that needs a revamp anyway per #958. Maybe just replace it with <code data-x="">Error</code> for now.

@annevk
Copy link
Member

annevk commented Jan 11, 2021

The existing usage sites of "convert" also need to be updated to link to the new definition in Infra.

Base automatically changed from master to main January 15, 2021 07:58
@annevk
Copy link
Member

annevk commented Jan 15, 2021

@momdo note that this is still incomplete. The references to the convert term need to be updated as well. Let me know if you'd like help.

@momdo
Copy link
Contributor Author

momdo commented Jan 16, 2021

@annevk Thanks for replying. For the term convert, could I simply replace it for instance as follows?

Before:

<li><p>Replace <var>name</var> with the result of <span>converting to a sequence of Unicode
   scalar values</span>.</p></li>

After:

<li><p>Replace <var>name</var> with the result of <span>convert</span>.</p></li>

If such a replacement is incorrect, please let me know how to rewrite it.

@annevk
Copy link
Member

annevk commented Jan 18, 2021

How about:

Set <var>name</var> to the result of <span data-x="convert">converting</span> <var>name</var>.

@momdo
Copy link
Contributor Author

momdo commented Jan 23, 2021

@annevk Thank you for comment. Fixed them.

@annevk annevk merged commit 31b3458 into whatwg:main Jan 25, 2021
@annevk
Copy link
Member

annevk commented Jan 25, 2021

Thanks @momdo!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants