Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hooks for other specifications to observe navigation #6496

Merged
merged 7 commits into from
Jul 13, 2021

Commits on Jun 25, 2021

  1. Add hooks for other specifications to observe navigation

    This change is motivated by specifications, notably WebDriver-BiDi,
    that want to observe the progress of navigations. Currently
    specifications that want to do this effectively monkeypatch HTML by
    writing "when <some stageis reached>, run the following:". The aim
    here is to provide more definite integration points.
    
    Implementation wise, this adds a single new concept; a navigation id
    which is a unique id generated for each navigation. This enables
    consumers to tell when events are from the same navigation.
    
    On top of that, a navigation status struct is defined, with an id, a
    URL and a status. This is used as a uniform interface for
    communicating the navigation progress through all the integration
    points, even though not all fields are useful in all cases.
    
    The actual integration points added are:
    
    * Navigation started
    * Navigation failed
    * Download started
    * DOM load complete
    * Load complete
    
    In addition the navigate algorithm itself returns a navigation status,
    so that external specifications which initiate a navigation can get
    the associated navigation id (or find out that the navigation
    completed in the case of a fragment navigation).
    jgraham committed Jun 25, 2021
    Configuration menu
    Copy the full SHA
    7f40763 View commit details
    Browse the repository at this point in the history
  2. Fix review comments

    jgraham committed Jun 25, 2021
    Configuration menu
    Copy the full SHA
    596fe5f View commit details
    Browse the repository at this point in the history

Commits on Jul 6, 2021

  1. Configuration menu
    Copy the full SHA
    06fa251 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2989716 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    2a48428 View commit details
    Browse the repository at this point in the history
  4. Don't return a useful value from navigate, but put a WebDriver hook b…

    …efore each return point
    jgraham committed Jul 6, 2021
    Configuration menu
    Copy the full SHA
    c25da9d View commit details
    Browse the repository at this point in the history

Commits on Jul 8, 2021

  1. Editorial fixes

    domenic committed Jul 8, 2021
    Configuration menu
    Copy the full SHA
    f6c315b View commit details
    Browse the repository at this point in the history