Editorial: modernize timers spec #7348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In addition to general updates to use modern terminology and improved precision, this moves the Web IDL conversion note and example to after the algorithm, and removes the (exported) "list of active timers" concept since it's not something other specs should be messing with.
annevk
reviewed
Nov 22, 2021
| to <var>method context</var>.</p></li> | ||
| <li><p>Let <var>thisArg</var> be <var>global</var> if that is a <code>WorkerGlobalScope</code> | ||
| object; otherwise let <var>thisArg</var> be the <code>WindowProxy</code> that corresponds to | ||
| <var>global</var>.</p></li> |
There was a problem hiding this comment.
Should this instead be something like global's relevant Realm.[[GlobalEnv]].[[GlobalThisValue]]? (Elsewhere we use relevant Realm.[[GlobalEnv]]'s EnvironmentRecord's [[GlobalThisValue]] but JS itself does the shortcut there.)
There was a problem hiding this comment.
Possibly, but I'd kind of like to not spread that very-opaque pattern too far. Instead we should define a wrapper term that we can use. I'll file a separate issue for that.
annevk
approved these changes
Nov 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition to general updates to use modern terminology and improved precision, this moves the Web IDL conversion note and example to after the algorithm, and removes the (exported) "list of active timers" concept since it's not something other specs should be messing with.
This is the first step toward the refactoring mentioned in whatwg/dom#1032 (comment), but it includes only changes that are independently good for HTML, without consideration for other specs yet. I'll do a follow-on PR for those.
/timers-and-user-prompts.html ( diff )
/webappapis.html ( diff )