Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Per the spec, calling clearInterval in the interval's callback has no effect #7356

Closed
andreubotella opened this issue Nov 22, 2021 · 0 comments · Fixed by #7359
Closed

Per the spec, calling clearInterval in the interval's callback has no effect #7356

andreubotella opened this issue Nov 22, 2021 · 0 comments · Fixed by #7359

Comments

@andreubotella
Copy link
Member

In every browser, clearing an interval in that very interval's callback correctly cancels it, but the spec has a bug that makes that not work:

  1. After running the callback or evaling the string, if the repeat flag is true, the timer initialization steps run again (timer initialization steps 6.3). This happens whether or not handle has been removed from the map of active timers since step 6.1.
  2. Step 14 in the timer initialization steps will add an entry with handle to the map of active timers.

Step 6.3 should check whether handle is in the map of active timers, as 6.1 does, before running the timer initialization steps again.
andreubotella pushed a commit to web-platform-tests/wpt that referenced this issue Nov 22, 2021
Test that clearInterval works inside the interval's callback
e64ddbf 
Ref: whatwg/html#7356
@andreubotella andreubotella mentioned this issue Nov 22, 2021
Merged
@domenic domenic mentioned this issue Nov 22, 2021
Merged
andreubotella pushed a commit to web-platform-tests/wpt that referenced this issue Nov 23, 2021
Test that clearInterval works inside the interval's callback (#31698)
2948653 
Ref: whatwg/html#7356
domenic added a commit that referenced this issue Nov 23, 2021
@domenic
Fix clearInterval() in setInterval() callback
5b292f9 
Closes #7356.
@domenic domenic mentioned this issue Nov 23, 2021
Merged
3 tasks
annevk pushed a commit that referenced this issue Nov 24, 2021
@domenic
Fix clearInterval() in setInterval() callback
2fd43c3 
Tests: web-platform-tests/wpt#31698.

Closes #7356.
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this issue Nov 30, 2021
@moz-wptsync-bot
Bug 1742399 [wpt PR 31698] - Test that clearInterval works inside t…
54b73ea 
…he interval's callback, a=testonly

Automatic update from web-platform-tests
Test that `clearInterval` works inside the interval's callback (#31698)

Ref: whatwg/html#7356
--

wpt-commits: 2948653c47c2d84d14fbac0706d2b86ada41323a
wpt-pr: 31698
jamienicol pushed a commit to jamienicol/gecko that referenced this issue Nov 30, 2021
@moz-wptsync-bot
Bug 1742399 [wpt PR 31698] - Test that clearInterval works inside t…
a94bc6d 
…he interval's callback, a=testonly

Automatic update from web-platform-tests
Test that `clearInterval` works inside the interval's callback (#31698)

Ref: whatwg/html#7356
--

wpt-commits: 2948653c47c2d84d14fbac0706d2b86ada41323a
wpt-pr: 31698
mfreed7 pushed a commit to mfreed7/html that referenced this issue Jun 3, 2022
@domenic @mfreed7
Fix clearInterval() in setInterval() callback
4d1a90b 
Tests: web-platform-tests/wpt#31698.

Closes whatwg#7356.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix clearInterval() in setInterval() callback whatwg/html
1 participant
@andreubotella