Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a note about why dialog uses show/close #7817

Merged
merged 3 commits into from
Apr 21, 2022
Merged

Add a note about why dialog uses show/close #7817

merged 3 commits into from
Apr 21, 2022

Conversation

domenic
Copy link
Member

@domenic domenic commented Apr 12, 2022 •
edited by pr-preview bot
Loading

@domenic domenic added clarification Standard could be clearer topic: dialog The <dialog> element. labels Apr 12, 2022
@domenic domenic requested a review from mfreed7 April 12, 2022 21:51
mfreed7
mfreed7 approved these changes Apr 13, 2022
View reviewed changes
Copy link
Contributor

@mfreed7 mfreed7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, very well written. Thanks for making the logic easier to link to from other specs/explainers.

@domenic domenic requested a review from annevk April 14, 2022 15:01
annevk
annevk reviewed Apr 21, 2022
View reviewed changes
source Show resolved Hide resolved
source Show resolved Hide resolved
source Show resolved Hide resolved
annevk
annevk approved these changes Apr 21, 2022
View reviewed changes
Copy link
Member

@annevk annevk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Nice to have this in the spec.

@domenic domenic merged commit 5dbec34 into main Apr 21, 2022
@domenic domenic deleted the explain-dialog-method-names branch April 21, 2022 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@annevk annevk annevk approved these changes

@mfreed7 mfreed7 mfreed7 approved these changes

Assignees
No one assigned
Labels
clarification Standard could be clearer topic: dialog The <dialog> element.
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consider renaming <dialog>.close() to .hide()
3 participants
@domenic @annevk @mfreed7