-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set requests' render-blocking
flag when fetching resources for render-blocking elements
#7885
Conversation
@domenic PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for reviewing!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM. Tagging "do not merge yet" until the Fetch PR is landed.
I will be OOO next week. @annevk, if the Fetch PR lands while I am out, it'd be good to land this too :)
924569a
to
2a4ffba
Compare
The HTML-side counterpart is whatwg/html#7885. Fixes #1433.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few nits before we can merge
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for reviewing! Updated.
The Fetch-side counterpart is whatwg/fetch#1432.
This is also a minor follow-up of #7474.
blocking=render
attribute #7474blocking=render
attribute #7474(See WHATWG Working Mode: Changes for more details.)
/infrastructure.html ( diff )
/links.html ( diff )
/scripting.html ( diff )
/semantics.html ( diff )
/webappapis.html ( diff )