Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set requests' render-blocking flag when fetching resources for render-blocking elements #7885

Merged
merged 2 commits into from
Jun 1, 2022

Conversation

xiaochengh
Copy link
Contributor

@xiaochengh xiaochengh commented May 3, 2022

The Fetch-side counterpart is whatwg/fetch#1432.

This is also a minor follow-up of #7474.

(See WHATWG Working Mode: Changes for more details.)


/infrastructure.html ( diff )
/links.html ( diff )
/scripting.html ( diff )
/semantics.html ( diff )
/webappapis.html ( diff )

source Outdated Show resolved Hide resolved
source Outdated Show resolved Hide resolved
@xiaochengh
Copy link
Contributor Author

@domenic PTAL

source Outdated Show resolved Hide resolved
source Outdated Show resolved Hide resolved
source Outdated Show resolved Hide resolved
source Outdated Show resolved Hide resolved
source Outdated Show resolved Hide resolved
Copy link
Contributor Author

@xiaochengh xiaochengh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for reviewing!

source Outdated Show resolved Hide resolved
source Outdated Show resolved Hide resolved
source Outdated Show resolved Hide resolved
source Outdated Show resolved Hide resolved
source Outdated Show resolved Hide resolved
Copy link
Member

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM. Tagging "do not merge yet" until the Fetch PR is landed.

I will be OOO next week. @annevk, if the Fetch PR lands while I am out, it'd be good to land this too :)

@domenic domenic added topic: rendering topic: script topic: link do not merge yet Pull request must not be merged per rationale in comment labels May 6, 2022
@xiaochengh xiaochengh force-pushed the set-request-render-blocking branch from 924569a to 2a4ffba Compare May 23, 2022 21:43
source Outdated Show resolved Hide resolved
annevk pushed a commit to whatwg/fetch that referenced this pull request May 24, 2022
@domenic domenic removed the do not merge yet Pull request must not be merged per rationale in comment label Jun 1, 2022
Copy link
Member

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few nits before we can merge

source Show resolved Hide resolved
source Show resolved Hide resolved
source Show resolved Hide resolved
Copy link
Contributor Author

@xiaochengh xiaochengh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for reviewing! Updated.

source Show resolved Hide resolved
source Show resolved Hide resolved
source Show resolved Hide resolved
@domenic domenic merged commit a4ccf54 into whatwg:main Jun 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

2 participants