Set empty string for reflection of IDREF attributes #8352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I guess it'd be nice to wait for ARIA folks to review this too as @cookiecrook suggested on the issue (CC @jnurthen @spectranaut). |
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Oct 4, 2022
This implements the agreement on the following HTML issue: whatwg/html#8306 HTML PR is available at: whatwg/html#8352 It just always set the content attribute to the empty string in Element::SetElementAttribute() and Element::SetElementArrayAttribute(). The WPT test is updated accordingly to the new behavior. Bug: 1370977 Test: external/wpt/html/dom/aria-element-reflection.html Change-Id: I55e64df6ac4c3eb50667c1d0a5ba360a9369c978
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Oct 4, 2022
This implements the agreement on the following HTML issue: whatwg/html#8306 HTML PR is available at: whatwg/html#8352 It just always set the content attribute to the empty string in Element::SetElementAttribute() and Element::SetElementArrayAttribute(). The WPT test is updated accordingly to the new behavior. Bug: 1370977 Test: external/wpt/html/dom/aria-element-reflection.html Change-Id: I55e64df6ac4c3eb50667c1d0a5ba360a9369c978
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Oct 4, 2022
This implements the agreement on the following HTML issue: whatwg/html#8306 HTML PR is available at: whatwg/html#8352 It just always set the content attribute to the empty string in Element::SetElementAttribute() and Element::SetElementArrayAttribute(). The WPT test is updated accordingly to the new behavior. Bug: 1370977 Test: external/wpt/html/dom/aria-element-reflection.html Change-Id: I55e64df6ac4c3eb50667c1d0a5ba360a9369c978
annevk
added
normative change
do not merge yet
annevk
reviewed
Oct 4, 2022
mrego
force-pushed
the
idref-reflection-empty-string
branch
from
8b97023
to
d28581c
Compare
annevk
reviewed
Oct 5, 2022
To avoid issues with wrong IDs in IDREF attributes we set the content attribute's value to the empty string in the setter steps for Element and FrozenArray<Element>. Fixes whatwg#8306
mrego
force-pushed
the
idref-reflection-empty-string
branch
from
d28581c
to
9bacd9d
Compare
annevk
approved these changes
Oct 5, 2022
Thanks for the quick reviews. Both Chromium and WebKit patches have been approved, so it looks we're good regarding that. We'll wait for the accessibility folks to chime in here before merging anything. |
|
Yesterday this was discussed in the AOM meeting and people there were fine with the proposal. @cyns was wondering how things would look like in DevTools DOM tree view, but it looks like things could be improved there (I've reported an issue on Chromium about that: https://crbug.com/1372365), and it's something that is already happening when you reference something in a shadow-including ancestor. |
annevk
removed
the
do not merge yet
|
Thanks for the quick turnaround! |
webkit-early-warning-system
pushed a commit
to mrego/WebKit
that referenced
this pull request
Oct 7, 2022
https://bugs.webkit.org/show_bug.cgi?id=245299 This implements the agreement on the following HTML issue: whatwg/html#8306 HTML PR is available at: whatwg/html#8352 It just always set the content attribute to the empty string in Element::setElementAttribute() and Element::setElementsArrayAttribute(). The tests are updated accordingly to the new behavior. Reviewed by Ryosuke Niwa. * LayoutTests/accessibility/ARIA-reflection-expected.txt: * LayoutTests/accessibility/ARIA-reflection.html: * LayoutTests/fast/custom-elements/reactions-for-aria-element-attributes.html: * LayoutTests/imported/w3c/web-platform-tests/html/dom/aria-element-reflection-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/html/dom/aria-element-reflection.html: * Source/WebCore/dom/Element.cpp: (WebCore::Element::setElementAttribute): (WebCore::Element::setElementsArrayAttribute): Canonical link: https://commits.webkit.org/255267@main
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Oct 7, 2022
This implements the agreement on the following HTML issue: whatwg/html#8306 HTML PR is available at: whatwg/html#8352 It just always set the content attribute to the empty string in Element::SetElementAttribute() and Element::SetElementArrayAttribute(). The WPT test is updated accordingly to the new behavior. Bug: 1370977 Test: external/wpt/html/dom/aria-element-reflection.html Change-Id: I55e64df6ac4c3eb50667c1d0a5ba360a9369c978 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3934330 Reviewed-by: Mason Freed <masonf@chromium.org> Reviewed-by: Joanmarie Diggs <jdiggs@igalia.com> Commit-Queue: Manuel Rego <rego@igalia.com> Cr-Commit-Position: refs/heads/main@{#1056288}
mrego
added a commit
to web-platform-tests/wpt
that referenced
this pull request
Oct 7, 2022
This implements the agreement on the following HTML issue: whatwg/html#8306 HTML PR is available at: whatwg/html#8352 It just always set the content attribute to the empty string in Element::SetElementAttribute() and Element::SetElementArrayAttribute(). The WPT test is updated accordingly to the new behavior. Bug: 1370977 Test: external/wpt/html/dom/aria-element-reflection.html Change-Id: I55e64df6ac4c3eb50667c1d0a5ba360a9369c978 Co-authored-by: Manuel Rego Casasnovas <rego@igalia.com>
mjfroman
pushed a commit
to mjfroman/moz-libwebrtc-third-party
that referenced
this pull request
Oct 14, 2022
This implements the agreement on the following HTML issue: whatwg/html#8306 HTML PR is available at: whatwg/html#8352 It just always set the content attribute to the empty string in Element::SetElementAttribute() and Element::SetElementArrayAttribute(). The WPT test is updated accordingly to the new behavior. Bug: 1370977 Test: external/wpt/html/dom/aria-element-reflection.html Change-Id: I55e64df6ac4c3eb50667c1d0a5ba360a9369c978 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3934330 Reviewed-by: Mason Freed <masonf@chromium.org> Reviewed-by: Joanmarie Diggs <jdiggs@igalia.com> Commit-Queue: Manuel Rego <rego@igalia.com> Cr-Commit-Position: refs/heads/main@{#1056288} NOKEYCHECK=True GitOrigin-RevId: f3d72d87337ce676ab43947a574c8c8ea6bfe998
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Oct 21, 2022
… attributes, a=testonly Automatic update from web-platform-tests Set empty string for reflection of IDREF attributes (#36253) This implements the agreement on the following HTML issue: whatwg/html#8306 HTML PR is available at: whatwg/html#8352 It just always set the content attribute to the empty string in Element::SetElementAttribute() and Element::SetElementArrayAttribute(). The WPT test is updated accordingly to the new behavior. Bug: 1370977 Test: external/wpt/html/dom/aria-element-reflection.html Change-Id: I55e64df6ac4c3eb50667c1d0a5ba360a9369c978 Co-authored-by: Manuel Rego Casasnovas <rego@igalia.com> -- wpt-commits: 18ef9afe94b628d25548754216b9636cebada489 wpt-pr: 36253
jamienicol
pushed a commit
to jamienicol/gecko
that referenced
this pull request
Oct 26, 2022
… attributes, a=testonly Automatic update from web-platform-tests Set empty string for reflection of IDREF attributes (#36253) This implements the agreement on the following HTML issue: whatwg/html#8306 HTML PR is available at: whatwg/html#8352 It just always set the content attribute to the empty string in Element::SetElementAttribute() and Element::SetElementArrayAttribute(). The WPT test is updated accordingly to the new behavior. Bug: 1370977 Test: external/wpt/html/dom/aria-element-reflection.html Change-Id: I55e64df6ac4c3eb50667c1d0a5ba360a9369c978 Co-authored-by: Manuel Rego Casasnovas <rego@igalia.com> -- wpt-commits: 18ef9afe94b628d25548754216b9636cebada489 wpt-pr: 36253
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid issues with wrong IDs in IDREF attributes we set the content attribute's value to the empty string in the setter steps for Element and FrozenArray.
Fixes #8306
/common-dom-interfaces.html ( diff )