Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

add scrollend event details #8433

Merged
merged 4 commits into from
Nov 1, 2022
Merged

add scrollend event details #8433

merged 4 commits into from
Nov 1, 2022

Conversation

argyleink
Copy link
Contributor

@argyleink argyleink commented Oct 25, 2022


Looks like I'll need help with the MDN issue? 馃檪

I'm not positive about Firefox or Safari's implementation interest at the moment, but they've historically been positive about it. It's also now separated from overscroll events, which should help out since it's a much smaller task now.

fixes w3c/csswg-drafts#7949


/dom.html ( diff )
/indices.html ( diff )
/infrastructure.html ( diff )
/webappapis.html ( diff )

Copy link
Member

@dlrobertson dlrobertson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not positive about Firefox or Safari's implementation interest at the moment, but they've historically been positive

I'm new-ish, so I know very little how these things work, but Mozilla standards positions mozilla/standards-positions#240 seems to agree. FWIW the work for the particular change is tracked in bug 1797013.

source Show resolved Hide resolved
source Show resolved Hide resolved
@domenic
Copy link
Member

domenic commented Oct 26, 2022

Where is the spec that actually defines where this is fired? HTML is a good place to put the updates to GlobalEventHandlers, but that comes after actually defining and specifying the event.

Note that we need to reference the definition, so you'll likely need to add something for that, similar to e.g. line 3095 for event-slotchange.

@argyleink
Copy link
Contributor Author

@domenic
Copy link
Member

domenic commented Oct 27, 2022

OK, cool. Please update the PR to link to the definition at https://drafts.csswg.org/cssom-view/#eventdef-document-scrollend like I noted above, similar to e.g. line 3095 for event-slotchange.

@argyleink
Copy link
Contributor Author

thx for the help y'all

@domenic
Copy link
Member

domenic commented Oct 28, 2022

Sorry, this still isn't correct... you need to add something to the dependencies section, similar to line 3095. You can't just add data-x-href in the table. I really suggest copying slotchange pretty exactly, if you can.

@argyleink
Copy link
Contributor Author

Sorry, this still isn't correct... you need to add something to the dependencies section, similar to line 3095. You can't just add data-x-href in the table. I really suggest copying slotchange pretty exactly, if you can.

gotcha. the reason i didnt just straight copy that LOC is because I didnt see scroll defined anywhere like that. i'll update to add a scrollend entry next to slotchange and take the x-href off where I added it 馃憤馃徎

@argyleink
Copy link
Contributor Author

cool, how's that @domenic?

Copy link
Member

@dlrobertson dlrobertson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for working on this!

source Outdated Show resolved Hide resolved
Copy link
Member

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Waiting on implementer interest, then we can merge.

@domenic domenic added topic: events addition/proposal New features or enhancements labels Oct 31, 2022
@dlrobertson
Copy link
Member

Implemented this in bug 1797013, so you can definitely add Gecko to implementers that are interested 馃槃

@argyleink
Copy link
Contributor Author

mdn issue added
noted firefox implementor interest
馃憤馃徎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
addition/proposal New features or enhancements topic: events
Development

Successfully merging this pull request may close these issues.

[cssom-view] migration of the scrollend event did not include onscrollend
3 participants