Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Meta: use <p> for subheading instead of <h2> #8473

Merged
merged 2 commits into from
Nov 7, 2022
Merged

Meta: use <p> for subheading instead of <h2> #8473

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
97404f5
Meta: use <p> for subheading instead of <h2>
domenic Nov 4, 2022
ffffd49
restore IDs
annevk Nov 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 3 additions & 3 deletions dev/styles.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ h1 {
font-size: 300%;
}

h2:not(#dev-edition-h2):not(#about-dev-edition) {
h2:not(#about-dev-edition) {
font-size: 160%;
text-transform: uppercase;
letter-spacing: 0.2em;
Expand Down Expand Up @@ -349,7 +349,7 @@ header#head h1 a:hover {
text-shadow: 0 0 5px rgba(0, 0, 0, 0.6);
}

header#head h2 {
header#head hgroup p {
font-size: 12px;
margin-bottom: 0.5em;
font-family: "Droid Serif", Georgia, serif;
Expand Down Expand Up @@ -513,7 +513,7 @@ html:not(.index) ol.toc ol {
height: auto;
}

h2:not(#dev-edition-h2) {
h2 {
font-size: 18px;
}

Expand Down
14 changes: 4 additions & 10 deletions source
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,19 +54,13 @@
<a href="https://whatwg.org/" class="logo"><img crossorigin width="100" height="100" alt="WHATWG" src="https://resources.whatwg.org/logo.svg"></a>
<hgroup w-nodev>
<h1 class="allcaps">HTML</h1>
<h2 w-nosnap w-noreview id="living-standard" class="no-num no-toc">Living Standard &mdash; Last Updated <span class="pubdate">[DATE: 01 Jan 1901]</span></h2>
<h2 w-nohtml w-noreview id="living-standard" class="no-num no-toc">Commit Snapshot &mdash; Last Updated <span class="pubdate">[DATE: 01 Jan 1901]</span></h2>
<h2 w-nohtml w-nosnap id="living-standard" class="no-num no-toc">Review Draft &mdash; Published <span class="pubdate">[DATE: 01 Jan 1901]</span></h2>
<!-- FIXME: once the spec is changed to allow p elements in hgroup to pass validation,
the h2s above needs to be changed to p elements, and the appropriate style sheets updated.
-->
<p w-nosnap w-noreview id="living-standard">Living Standard &mdash; Last Updated <span class="pubdate">[DATE: 01 Jan 1901]</span></p>
<p w-nohtml w-noreview id="living-standard">Commit Snapshot &mdash; Last Updated <span class="pubdate">[DATE: 01 Jan 1901]</span></p>
<p w-nohtml w-nosnap id="living-standard">Review Draft &mdash; Published <span class="pubdate">[DATE: 01 Jan 1901]</span></p>
</hgroup>
<hgroup w-dev>
<h1><a href="/dev/" rel=home>HTML: The Living Standard</a></h1>
<h2 class="no-num no-toc" id="dev-edition-h2">Edition for Web Developers &mdash; Last Updated <span class="pubdate">[DATE: 01 Jan 1901]</span></h2>
<!-- FIXME: once the spec is changed to allow p elements in hgroup to pass validation,
the h2 above needs to be changed to p elements, and the appropriate style sheets updated.
-->
<p id="dev-edition-h2">Edition for Web Developers &mdash; Last Updated <span class="pubdate">[DATE: 01 Jan 1901]</span></p>
</hgroup>
<nav w-nosplit w-nodev w-noreview>
<!-- Note: be sure to keep an even number of <a>s, for small screens where they appear in two columns. -->
Expand Down