Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editorial: Finish removing unused script-fetching param #9510

Merged
merged 1 commit into from
Jul 13, 2023

Conversation

domfarolino
Copy link
Member

@domfarolino domfarolino commented Jul 12, 2023

#9508 landed to fix #9499, by removing the "fetch client settings object" param from the #fetch-the-descendants-of-and-link-a-module-script algorithm, but that PR accidentally only removed the passing-in of that argument from the callers, without properly updating the signature of the algorithm. This PR finishes the job by removing the parameter from the signature altogether.


/webappapis.html ( diff )

@domenic domenic merged commit e2d386b into main Jul 13, 2023
2 checks passed
@domenic domenic deleted the domfarolino/script-param-really branch July 13, 2023 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

fetch client settings object isn't used in fetch the descendants of and link a module script
2 participants