Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editorial: Remove unused param from "fetch the descendants of and link a module script" #9508

Merged
merged 1 commit into from
Jul 12, 2023
Merged

Editorial: Remove unused param from "fetch the descendants of and link a module script" #9508

merged 1 commit into from
Jul 12, 2023

Conversation

domfarolino
Copy link
Member

@domfarolino domfarolino commented Jul 11, 2023 •
edited by pr-preview bot

This closes #9499; see the rationale there for why this extra parameter existed in the first place.

/webappapis.html ( diff )

@domfarolino domfarolino requested a review from domenic July 11, 2023 21:29
domenic
domenic approved these changes Jul 12, 2023
View reviewed changes
Copy link
Member

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@domenic domenic merged commit 1c634cf into main Jul 12, 2023
2 checks passed
@domenic domenic deleted the domfarolino/fetch-descendant-param branch July 12, 2023 00:24
@domfarolino domfarolino mentioned this pull request Jul 12, 2023
Merged
@nicolo-ribaudo nicolo-ribaudo mentioned this pull request Jul 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@domenic domenic domenic approved these changes

Assignees
No one assigned
Labels
topic: script
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fetch client settings object isn't used in fetch the descendants of and link a module script
2 participants
@domfarolino @domenic