Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change subframe traverse navigate event timing #9922

Merged
merged 1 commit into from
Nov 15, 2023

Conversation

domenic
Copy link
Member

@domenic domenic commented Nov 10, 2023

This fires navigate events for subframes during a traversal earlier, before the unload event and in parallel with any fetches that occur. This is more consistent with non-traverse navigate events, and with top-level traverse navigate events.

WICG/navigation-api#207 has some previous relevant discussion. This represents moving from that issue's "late" navigate events to "early-but-still-async". It turns out the complexity was not too bad, when we got around to it in Chromium, and was actually helpful in order to fix a bug where traverse navigate events weren't firing when pages were bfcached.

(See WHATWG Working Mode: Changes for more details.)


/browsing-the-web.html ( diff )

This fires navigate events for subframes during a traversal earlier, before the unload event and in parallel with any fetches that occur. This is more consistent with non-traverse navigate events, and with top-level traverse navigate events.
Copy link
Member

@domfarolino domfarolino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change looks good, thanks for the context in the OP too.

@domenic domenic merged commit beae854 into main Nov 15, 2023
2 checks passed
@domenic domenic deleted the navigate-event-timing-tweak branch November 15, 2023 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants