Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Annevk/noncharacter #114

Merged
merged 3 commits into from
Apr 3, 2017
Merged

Annevk/noncharacter #114

merged 3 commits into from
Apr 3, 2017

Conversation

annevk
Copy link
Member

@annevk annevk commented Mar 29, 2017 •
edited by pr-preview bot
Loading

@annevk
Copy link
Member Author

annevk commented Mar 29, 2017

It's not entirely clear to me what the best place for noncharacter is. Before we continue with this PR I'd first like to work on corresponding PRs for URL and HTML to make sure this actually helps.

@annevk
Copy link
Member Author

annevk commented Mar 29, 2017

Commit message note: this fixes #108.

annevk added a commit to whatwg/html that referenced this pull request Mar 29, 2017
@annevk
Editorial: use non character and control from Infra
b8a479a 
See whatwg/infra#114 for the change to Infra.
@annevk annevk mentioned this pull request Mar 29, 2017
Merged
@annevk
Copy link
Member Author

annevk commented Mar 29, 2017

HTML could maybe use a definition of controls that excludes ASCII whitespace.

annevk added a commit to whatwg/url that referenced this pull request Mar 29, 2017
@annevk
Editorial: use noncharacter from Infra
19e6d7c 
See whatwg/infra#114 for the change to Infra.
@annevk annevk mentioned this pull request Mar 29, 2017
Merged
@annevk
Copy link
Member Author

annevk commented Mar 29, 2017

I think it helps in terms of readability in both, but someone else should give it a look over as well.

@annevk annevk requested a review from domenic March 30, 2017 10:22
domenic
domenic reviewed Mar 30, 2017
View reviewed changes
infra.bs
inclusive, or U+FFFE, U+FFFF, U+1FFFE, U+1FFFF, U+2FFFE, U+2FFFF, U+3FFFE, U+3FFFF, U+4FFFE,
U+4FFFF, U+5FFFE, U+5FFFF, U+6FFFE, U+6FFFF, U+7FFFE, U+7FFFF, U+8FFFE, U+8FFFF, U+9FFFE, U+9FFFF,
U+AFFFE, U+AFFFF, U+BFFFE, U+BFFFF, U+CFFFE, U+CFFFF, U+DFFFE, U+DFFFF, U+EFFFE, U+EFFFF, U+FFFFE,
U+FFFFF, U+10FFFE, or U+10FFFF.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we explain why these characters are chosen? Apparently they are "permanently undefined" per Unicode?

Still not sure about whether we should be defining explicit ranges or referencing Unicode.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Opened #117 to sort this out, but I don't think that needs to block this, as we don't explain "surrogate" or "scalar value" in much detail either.

domenic
domenic approved these changes Apr 3, 2017
View reviewed changes
Copy link
Member

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess LGTM then, although we should resolve #117 sooner rather than later.

@annevk annevk merged commit ad1b87a into master Apr 3, 2017
@zcorpan zcorpan deleted the annevk/noncharacter branch April 3, 2017 10:09
annevk added a commit to whatwg/html that referenced this pull request Apr 3, 2017
@annevk
Editorial: use noncharacter and control from Infra
7092523 
See whatwg/infra#114 for the change to Infra.
@annevk annevk mentioned this pull request Apr 3, 2017
Closed
annevk added a commit to whatwg/url that referenced this pull request Apr 7, 2017
@annevk
Editorial: use noncharacter from Infra
4a4c559 
See whatwg/infra#114 for the change to Infra.
inikulin pushed a commit to HTMLParseErrorWG/html that referenced this pull request May 9, 2017
@annevk @inikulin
Editorial: use noncharacter and control from Infra
5e614bc 
See whatwg/infra#114 for the change to Infra.
inikulin pushed a commit to HTMLParseErrorWG/html that referenced this pull request May 9, 2017
@annevk @inikulin
Editorial: use noncharacter and control from Infra
739feaf 
See whatwg/infra#114 for the change to Infra.
@domenic domenic mentioned this pull request May 31, 2017
Merged
alice pushed a commit to alice/html that referenced this pull request Jan 8, 2019
@annevk
Editorial: use noncharacter and control from Infra
a68ef3a 
See whatwg/infra#114 for the change to Infra.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@domenic domenic domenic approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@annevk @domenic