Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fold deploy.sh into a GitHub Action? #287

Open
tabatkins opened this issue Jul 24, 2023 · 2 comments
Open

Fold deploy.sh into a GitHub Action? #287

tabatkins opened this issue Jul 24, 2023 · 2 comments

Comments

@tabatkins
Copy link

In the WHATWG chatroom, @jgraham suggested folding the deploy.sh script into the GitHub Action for triggering deploys, so contributors don't have to worry about running make deploy.

I don't have enough insight into what the deploy script does to know if it's useful to run locally or if it does things that are awkward to express in GH Actions.

@domenic
Copy link
Member

domenic commented Jul 25, 2023

I prefer being able to run it locally and check and debug the output. I don't see any advantages of this.

Contributors generally don't need to know about make deploy, so I'm not sure why that is brought up.

@jgraham
Copy link
Member

jgraham commented Jul 26, 2023

Contributors generally do need to know about it because currently the only way to figure out how to build WHATWG specs is to either a) notice there's a Makefile and read it, or b) read https://github.com/whatwg/meta/blob/main/CONTRIBUTING.md where make deploy is (unintentionally) the most prominent thing under "Building".

In any case the deploy target seems to be a two line shell script that first downloads the latest version of another shell script and then runs it. It seems like it would be totally possible for the few people who want to use this just to have that two line script somewhere on their path, and in CI you can just put the two lines directly in the GH actions workflow.

But of course that only makes sense if you first remove the dependency on make for the common use case of local builds, and then also want to stop using it entirely. To me that would be an improvement, because as a simple frontend the way it's used for WHATWG specs I consider make to offer negative value. But as long as one can make a build only using the standard toolchain (i.e. bikeshed spec) I care much less about how you organise the code for advanced use cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants