Use collect an HTTP quoted string #92
Conversation
mimesniff.bs
Outdated
|
|
||
| <li> | ||
| <p>While true: | ||
| <p>Set <var>parameterValue</var> and <var>unneeded</var> to the result of | ||
| <a>collecting an HTTP quoted string</a> from <var>input</var>, given <var>position</var>. |
There was a problem hiding this comment.
Maybe Fetch should have a wrapper algorithm that does the "unneeded" stuff for you?
|
I ended up adding a flag to the collecting algorithm so you it can have a single return value. It looks reasonably clean now. |
mimesniff.bs
Outdated
| <li><p>Otherwise, <a for=iteration>break</a>. | ||
| </ol> | ||
| <li><p>Set <var>parameterValue</var> to the result of <a>collecting an HTTP quoted string</a> | ||
| from <var>input</var>, given <var>position</var> and the <var>extract-value flag</var>. |
There was a problem hiding this comment.
"var" is a bit weird here (e.g. that variable was never declared). But we don't have a good story for flags anyway, so I don't know what to really recommend.
There was a problem hiding this comment.
Previously you recommended <var> when I was using <i> for them.
There was a problem hiding this comment.
At the definition site that makes sense, but at the call site it's weird. But the whole setup has no obviously good answers so anything goes for now.
|
Note to self: this can likely land tomorrow once Fetch is reindexed. |
…ff#92. No functional changes.
Follows whatwg/mimesniff#92. No functional changes.
See whatwg/fetch#831.
Preview | Diff