Define the Content-Type header parser #831

annevk · 2018-11-09T14:30:02Z

Also known as "extract a MIME type" down right.

Helps with #814.

Also known as "extract a MIME type" down right. Tests: web-platform-tests/wpt#10525. Helps with #814. Fixes #529. Closes whatwg/mimesniff#30.

fetch.bs

domenic

Some clarity suggestions. Very exciting stuff.

fetch.bs

domenic · 2018-11-12T17:40:09Z

Oh, also, should the new Content-Type header section mention that "extract a MIME type" is meant only for use on responses? Maybe the algorithm name should be more specific, e.g. "parse the response Content-Type header"?

annevk · 2018-11-13T08:23:11Z

My plan was that we use the algorithm for Content-Type for both requests and responses, but have a stricter parser solely for CORS purposes. It seemed better for Request and Response in particular to not deviate here in how they determine the MIME type for a Blob.

This aligns with the changes made in whatwg/fetch#831. Fortunately the remainder of the prose already assumed it got a MIME type record rather than bytes.

annevk · 2018-11-13T15:47:01Z

@MattMenke2 @bzbarsky any final thoughts here? I realize this doesn't match browsers 100% due to eager combining, but it feels like the only sensible model to specify given that intermediaries are allowed to combine. Hopefully given enough time browsers can converge on this model. And if they can't, we can revisit…

fetch.bs

bzbarsky · 2018-11-13T17:37:54Z

I don't really understand this space well enough at this point to comment intelligently...

See whatwg/fetch#831.

annevk · 2018-11-14T11:25:40Z

@MattMenke2 I created an algorithm for collecting an HTTP quoted string based on the MIME type parser (and also created whatwg/mimesniff#92 to use it there). It's a little ugly as here we care about moving the position only whereas in the MIME type parser we also care about extracting a value, but this seemed like a reasonable compromise that would not lead to code duplication. (I'd be open to changing the algorithm to take a boolean to return one or the other value in the end, rather than both.)

annevk · 2018-11-15T16:19:28Z

There's now additional tests for escaped quotes as well.

MattMenke2

This all looks pretty good to me.

fetch.bs

…fy life for callers

domenic

Really great, thanks for all the iteration! Only a couple minor suggestions.

fetch.bs

annevk · 2018-11-27T09:44:39Z

Bugs:

See whatwg/fetch#831 for context.

See whatwg/fetch#831.

Automatic update from web-platform-tests Fetch: Content-Type parsing See whatwg/fetch#831 for context. -- wpt-commits: 62317fb983ca5687e4133d89f5523839fdab7f69 wpt-pr: 10525

This aligns with the changes made in whatwg/fetch#831. Fortunately the remainder of the prose already assumed it got a MIME type record rather than bytes.

Automatic update from web-platform-tests Fetch: Content-Type parsing See whatwg/fetch#831 for context. -- wpt-commits: 62317fb983ca5687e4133d89f5523839fdab7f69 wpt-pr: 10525 UltraBlame original commit: f49a14324463677b56f2a95835bb072c6bd9e378

Automatic update from web-platform-tests Fetch: Content-Type parsing See whatwg/fetch#831 for context. -- wpt-commits: 62317fb983ca5687e4133d89f5523839fdab7f69 wpt-pr: 10525 UltraBlame original commit: 3654829da79864d0ca79d12ef226c2cb3a45729f

Automatic update from web-platform-tests Fetch: Content-Type parsing See whatwg/fetch#831 for context. -- wpt-commits: 62317fb983ca5687e4133d89f5523839fdab7f69 wpt-pr: 10525 UltraBlame original commit: f49a14324463677b56f2a95835bb072c6bd9e378

Automatic update from web-platform-tests Fetch: Content-Type parsing See whatwg/fetch#831 for context. -- wpt-commits: 62317fb983ca5687e4133d89f5523839fdab7f69 wpt-pr: 10525 UltraBlame original commit: 3654829da79864d0ca79d12ef226c2cb3a45729f

Automatic update from web-platform-tests Fetch: Content-Type parsing See whatwg/fetch#831 for context. -- wpt-commits: 62317fb983ca5687e4133d89f5523839fdab7f69 wpt-pr: 10525 UltraBlame original commit: f49a14324463677b56f2a95835bb072c6bd9e378

Automatic update from web-platform-tests Fetch: Content-Type parsing See whatwg/fetch#831 for context. -- wpt-commits: 62317fb983ca5687e4133d89f5523839fdab7f69 wpt-pr: 10525 UltraBlame original commit: 3654829da79864d0ca79d12ef226c2cb3a45729f

This aligns with the changes made in whatwg/fetch#831. Fortunately the remainder of the prose already assumed it got a MIME type record rather than bytes.

annevk mentioned this pull request Nov 9, 2018

Content-Type parsing (MIME type parsing) whatwg/mimesniff#30

Closed

Define the response Content-Type header parser

a28d42c

Also known as "extract a MIME type" down right. Tests: web-platform-tests/wpt#10525. Helps with #814. Fixes #529. Closes whatwg/mimesniff#30.

annevk force-pushed the annevk/response-content-type branch from e259098 to a28d42c Compare November 12, 2018 13:01

annevk commented Nov 12, 2018

View reviewed changes

fetch.bs Outdated Show resolved Hide resolved

annevk added 3 commits November 12, 2018 16:55

correct some omissions

d9164cd

move content-type parsing to its own section and add some context

ec0a86a

use result of extracting a MIME type correctly within Fetch

e622e48

annevk commented Nov 12, 2018

View reviewed changes

fetch.bs Outdated Show resolved Hide resolved

domenic reviewed Nov 12, 2018

View reviewed changes

annevk mentioned this pull request Nov 13, 2018

"Extract a MIME type" algorithm should pick the first entry? #529

Closed

address feedback

5f7cd8f

annevk changed the title ~~Define the response Content-Type header parser~~ Define the Content-Type header parser Nov 13, 2018

annevk added 2 commits November 13, 2018 13:21

oh bs

45a4d41

(ignoring parameters) be gone

e9e8dbc

annevk added a commit to whatwg/xhr that referenced this pull request Nov 13, 2018

Extract a MIME type no longer returns bytes

18924f9

This aligns with the changes made in whatwg/fetch#831. Fortunately the remainder of the prose already assumed it got a MIME type record rather than bytes.

This was referenced Nov 13, 2018

Extract a MIME type no longer returns bytes whatwg/xhr#227

Merged

Redesign "extract header values" and "extract header list values" #814

Open

Content-Type header parsing httpwg/http-core#39

Closed

MattMenke2 reviewed Nov 13, 2018

View reviewed changes

fetch.bs Outdated Show resolved Hide resolved

fetch.bs Show resolved Hide resolved

annevk added a commit to whatwg/mimesniff that referenced this pull request Nov 14, 2018

Use collect an HTTP quoted string

1389eec

See whatwg/fetch#831.

annevk mentioned this pull request Nov 14, 2018

Use collect an HTTP quoted string whatwg/mimesniff#92

Merged

do quoted strings properly

c789062

oops

3eb6d14

MattMenke2 reviewed Nov 16, 2018

View reviewed changes

fetch.bs Outdated Show resolved Hide resolved

fetch.bs Show resolved Hide resolved

fetch.bs Outdated Show resolved Hide resolved

fetch.bs Outdated Show resolved Hide resolved

domenic reviewed Nov 20, 2018

View reviewed changes

fetch.bs Outdated Show resolved Hide resolved

domenic reviewed Nov 21, 2018

View reviewed changes

annevk added 6 commits November 21, 2018 12:45

nest less (not a 100% sure this is better)

3185710

address remaining feedback

2386726

domenic asking for examples revealed a bug to me

2d5d2a9

give collecting an HTTP quoted string an extract-value flag to simpli…

ccc6f14

…fy life for callers

add CORS example

0670924

personal nit

c1f48b3

domenic approved these changes Nov 22, 2018

View reviewed changes

fetch.bs Show resolved Hide resolved

fetch.bs Outdated Show resolved Hide resolved

final commit?

eed035b

MattMenke2 approved these changes Nov 26, 2018

View reviewed changes

annevk merged commit 0b2bc05 into master Nov 27, 2018

annevk deleted the annevk/response-content-type branch November 27, 2018 09:47

annevk added a commit to web-platform-tests/wpt that referenced this pull request Nov 27, 2018

Fetch: Content-Type parsing

62317fb

See whatwg/fetch#831 for context.

annevk added a commit to whatwg/mimesniff that referenced this pull request Nov 28, 2018

Use collect an HTTP quoted string from Fetch

8e9a7dd

See whatwg/fetch#831.

annevk added a commit to whatwg/xhr that referenced this pull request Mar 24, 2019

Extract a MIME type no longer returns bytes

cf97f4e

This aligns with the changes made in whatwg/fetch#831. Fortunately the remainder of the prose already assumed it got a MIME type record rather than bytes.

annevk mentioned this pull request Mar 21, 2022

[wasm-web-api-1] Don't use fetch's "extract a MIME type" WebAssembly/spec#1432

Closed

dlrobertson mentioned this pull request Oct 4, 2023

Fetch Web API - Content-type parsing web-platform-tests/interop#536

Closed

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Define the Content-Type header parser #831

Define the Content-Type header parser #831

annevk commented Nov 9, 2018 •

edited by pr-preview bot

Loading

domenic left a comment

domenic commented Nov 12, 2018

annevk commented Nov 13, 2018

annevk commented Nov 13, 2018

bzbarsky commented Nov 13, 2018

annevk commented Nov 14, 2018

annevk commented Nov 15, 2018

MattMenke2 left a comment

domenic left a comment

annevk commented Nov 27, 2018

Define the Content-Type header parser #831

Define the Content-Type header parser #831

Conversation

annevk commented Nov 9, 2018 • edited by pr-preview bot Loading

domenic left a comment

Choose a reason for hiding this comment

domenic commented Nov 12, 2018

annevk commented Nov 13, 2018

annevk commented Nov 13, 2018

bzbarsky commented Nov 13, 2018

annevk commented Nov 14, 2018

annevk commented Nov 15, 2018

MattMenke2 left a comment

Choose a reason for hiding this comment

domenic left a comment

Choose a reason for hiding this comment

annevk commented Nov 27, 2018

annevk commented Nov 9, 2018 •

edited by pr-preview bot

Loading