Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restrict Notifications to secure contexts. #176

Merged
merged 10 commits into from Nov 23, 2021
Merged

Restrict Notifications to secure contexts. #176

Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
e07fd93
Remove Permission model section.
miketaylr Nov 19, 2021
51aff35
Add <dfn>get the notifications permission state</dfn>.
miketaylr Nov 19, 2021
daefe12
Update constructor to use <dfn>getting the notifications permission s…
miketaylr Nov 19, 2021
2e61c62
Update SW API to use <dfn>getting the notifications permission state<…
miketaylr Nov 19, 2021
f3cdc87
Update static getters to use <dfn>getting the notifications permissio…
miketaylr Nov 19, 2021
78937c4
Restrict Notifications to secure contexts.
miketaylr Nov 19, 2021
bbedb83
Apply @annevk's suggestions.
miketaylr Nov 22, 2021
090b8e3
Stray whitespace cleanup (thx GitHub)
miketaylr Nov 22, 2021
9571a2d
Notifications.requestPermssion should <a>request permission to use</a…
miketaylr Nov 22, 2021
4eff822
Another round o' Anne's suggested tweaks.
miketaylr Nov 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
67 changes: 17 additions & 50 deletions notifications.bs
View file
Open in desktop
Expand Up @@ -291,40 +291,21 @@ removed from the <a>list of notifications</a>.
"notification center" (if available).


<h3 id=permission-model>Permission model</h3>

<p><a>Notifications</a> can only be displayed if the
user (or user agent on behalf of the user) has granted <dfn>permission</dfn>.
The <a>permission</a> to show <a>notifications</a>
for a given <a for=/>origin</a> is one of three strings:

<dl>
<dt>"<code>default</code>"
<dd><p>This is equivalent to "<code>denied</code>", but the user has made no
explicit choice thus far.

<dt>"<code>denied</code>"
<dd><p>This means the user does not want
<a>notifications</a>.
<h3 id="permissions-integration">Permissions integration</h3>

<dt>"<code>granted</code>"
<dd><p>This means <a>notifications</a> can be
displayed.
</dl>
<p>The Notifications API is a <a>powerful feature</a> which is identified by the
<a for="powerful feature">name</a> "{{PermissionName/notifications}}". [[!Permissions]]

<p class=note>There is no equivalent to "<code>default</code>"
meaning "<code>granted</code>". In that case
"<code>granted</code>" is simply returned as there would be no reason
for the application to ask for <a>permission</a>.
<p>To <dfn>get the notifications permission state</dfn>, run these steps:

<h3 id="permissions-integration">Permissions integration</h3>
<ol>
<li><p>Let <var>permissionState</var> be the result of <a>getting the current permission state</a>
with "{{PermissionName/notifications}}".

<p>The Notifications API is a <a>powerful feature</a> which is identified by the string
"notifications" and has its <a for="powerful feature">allowed in non-secure contexts</a> flag set.
[[!Permissions]]
<li><p>If <var>permissionState</var> is "<code>prompt</code>", then return "<code>default</code>".

<p class="note">This specification's "<code>default</code>" <a>permission</a>
state maps to the [=permission/prompt=] permission state in the Permissions API.
<li><p>Return <var>permissionState</var>.
</ol>


<h3 id=direction>Direction</h3>
Expand Down Expand Up @@ -721,9 +702,9 @@ constructor steps are:
<p>Run these steps <a>in parallel</a>:

<ol>
<li><p>If <a>permission</a> for <var>notification</var>'s <a for=notification>origin</a> is not
"<code>granted</code>", then <a>queue a task</a> to <a>fire an event</a> named <code>error</code>
on <a>this</a>, and abort these steps.
<li><p>If the result of <a>getting the notifications permission state</a> is not
"<code>granted</code>", then <a>queue a task</a> to <a>fire an event</a> named
<code>error</code> on <a>this</a>, and abort these steps.

<li><p>Run the <a>fetch steps</a> for <var>notification</var>.

Expand All @@ -735,8 +716,7 @@ constructor steps are:
<h3 id=static-members>Static members</h3>

<p>The static <dfn attribute for=Notification><code>permission</code></dfn> getter steps are to
return the <a>permission</a> for the <a>current settings object</a>'s
<a for="environment settings object">origin</a>.
return the result of <a>getting the notifications permission state</a>.

<div class=note>
<p>If you edit standards please refrain from copying the above. Synchronous permissions are like
Expand All @@ -760,27 +740,14 @@ method steps are:
<ol>
<li><p>Let <var>global</var> be the <a>current global object</a>.

<li><p>Let <var>permissionDescriptor</var> be the {{PermissionDescriptor}} with
{{PermissionDescriptor/name}} set to "<code>notifications</code>".

<li><p>Let <var>permissionStatus</var> be the result of
<a lt="create a PermissionStatus">creating a `PermissionStatus`</a> for
<var>permissionDescriptor</var>.

<li><p>Let <var>promise</var> be <a for=/>a new promise</a> in <a>this</a>'s <a>relevant Realm</a>.

<li>
<p>Run these steps <a>in parallel</a>:

<ol>
<li><p>Run the <a for="powerful feature">permission query algorithm</a> with
<var>permissionDescriptor</var> and <var>permissionStatus</var>.

<li><p>Let <var>permissionState</var> be <var>permissionStatus</var>'s
{{PermissionStatus/state}}.

<li><p>If <var>permissionState</var> is {{PermissionState/"prompt"}}, then set
<var>permissionState</var> to "<code>default</code>".
<li><p>Let <var>permissionState</var> be the result of
<a>requesting permission to use</a> "{{PermissionName/notifications}}".

<li>
<p><a>Queue a global task</a> on the <a>DOM manipulation task source</a> given <var>global</var>
Expand Down Expand Up @@ -1083,7 +1050,7 @@ method steps are:
<p>Run these steps <a>in parallel</a>:

<ol>
<li><p>If <a>permission</a> for <var>notification</var>'s <a for=notification>origin</a> is not
<li><p>If the result of <a>getting the notifications permission state</a> is not
"<code>granted</code>", then <a>queue a global task</a> on the
<a>DOM manipulation task source</a> given <var>global</var> to <a for=/>reject</a>
<var>promise</var> with a {{TypeError}}, and abort these steps.
Expand Down