Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restrict Notifications to secure contexts. #176

Merged
merged 10 commits into from
Nov 23, 2021
Merged

Restrict Notifications to secure contexts. #176

merged 10 commits into from
Nov 23, 2021

Commits on Nov 19, 2021

  1. Remove Permission model section.

    @miketaylr
    miketaylr committed Nov 19, 2021
    Configuration menu
    Copy the full SHA
    e07fd93 View commit details
    Browse the repository at this point in the history

  2. Add <dfn>get the notifications permission state</dfn>. 

    Conveniently, this handles the secure context check for us, via
<dfn>get the current permissions state</dfn>.
    @miketaylr
    miketaylr committed Nov 19, 2021
    Configuration menu
    Copy the full SHA
    51aff35 View commit details
    Browse the repository at this point in the history

  3. Update constructor to use <dfn>getting the notifications permission s… 

    …tate</dfn>
    @miketaylr
    miketaylr committed Nov 19, 2021
    Configuration menu
    Copy the full SHA
    daefe12 View commit details
    Browse the repository at this point in the history

  4. Update SW API to use <dfn>getting the notifications permission state<… 

    …/dfn>
    @miketaylr
    miketaylr committed Nov 19, 2021
    Configuration menu
    Copy the full SHA
    2e61c62 View commit details
    Browse the repository at this point in the history

  5. Update static getters to use <dfn>getting the notifications permissio… 

    …n state</dfn>
    @miketaylr
    miketaylr committed Nov 19, 2021
    Configuration menu
    Copy the full SHA
    f3cdc87 View commit details
    Browse the repository at this point in the history

  6. Restrict Notifications to secure contexts.

    @miketaylr
    miketaylr committed Nov 19, 2021
    Configuration menu
    Copy the full SHA
    78937c4 View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2021

  1. Apply @annevk's suggestions. 

    Co-authored-by: Anne van Kesteren <annevk@annevk.nl>
    @miketaylr @annevk
    miketaylr and annevk committed Nov 22, 2021
    Configuration menu
    Copy the full SHA
    bbedb83 View commit details
    Browse the repository at this point in the history

  2. Stray whitespace cleanup (thx GitHub)

    @miketaylr
    miketaylr committed Nov 22, 2021
    Configuration menu
    Copy the full SHA
    090b8e3 View commit details
    Browse the repository at this point in the history

  3. Notifications.requestPermssion should <a>request permission to use</a… 

    …> "notifications"
    @miketaylr
    miketaylr committed Nov 22, 2021
    Configuration menu
    Copy the full SHA
    9571a2d View commit details
    Browse the repository at this point in the history

  4. Another round o' Anne's suggested tweaks. 

    Co-authored-by: Anne van Kesteren <annevk@annevk.nl>
    @miketaylr @annevk
    miketaylr and annevk committed Nov 22, 2021
    Configuration menu
    Copy the full SHA
    4eff822 View commit details
    Browse the repository at this point in the history