Default silent to platform convention #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
annevk
reviewed
May 10, 2023
annevk
reviewed
May 12, 2023
annevk
approved these changes
May 16, 2023
annevk
added
needs tests
|
Thanks for the proposal Marcos, agreed that the default should be platform specific, and is an overall improvement. The change looks good to me, and happy to apply the changes from the chromium side of things. |
|
Small set of tests are coming as part of WebKit/WebKit#13912 (reviewed upstream) I’ll send them to WPT hopefully tomorrow. |
|
Implementer bugs filed. |
annevk
added
addition/proposal
webkit-commit-queue
pushed a commit
to marcoscaceres/WebKit
that referenced
this pull request
May 23, 2023
https://bugs.webkit.org/show_bug.cgi?id=256828 rdar://109390045 Reviewed by Brady Eidson. Makes the silent member on the NotificationOption dictionary default to null. This is then reflected by the silent attribute of the Notification interface. Spec change: whatwg/notifications#194 * LayoutTests/imported/w3c/web-platform-tests/interfaces/notifications.idl: * LayoutTests/imported/w3c/web-platform-tests/notifications/constructor-basic.https-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/notifications/constructor-basic.https.html: * Source/WebCore/Modules/notifications/Notification.h: * Source/WebCore/Modules/notifications/Notification.idl: * Source/WebCore/Modules/notifications/NotificationOptions.idl: Canonical link: https://commits.webkit.org/264397@main
|
Tests sent at web-platform-tests/wpt#40160 (reviewed upstream) |
annevk
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
May 23, 2023
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Jun 10, 2023
… to null, a=testonly Automatic update from web-platform-tests Notifications: test that silent defaults to null For whatwg/notifications#194. -- wpt-commits: ac2c4415f6ea3f0d08a2d19f0e104ce447054db1 wpt-pr: 40160
ErichDonGubler
pushed a commit
to erichdongubler-mozilla/firefox
that referenced
this pull request
Jun 12, 2023
… to null, a=testonly Automatic update from web-platform-tests Notifications: test that silent defaults to null For whatwg/notifications#194. -- wpt-commits: ac2c4415f6ea3f0d08a2d19f0e104ce447054db1 wpt-pr: 40160
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Jun 16, 2023
… to null, a=testonly Automatic update from web-platform-tests Notifications: test that silent defaults to null For whatwg/notifications#194. -- wpt-commits: ac2c4415f6ea3f0d08a2d19f0e104ce447054db1 wpt-pr: 40160 UltraBlame original commit: e3ed9dae6c2e719eb3ca042485d5493caac92613
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Jun 16, 2023
… to null, a=testonly Automatic update from web-platform-tests Notifications: test that silent defaults to null For whatwg/notifications#194. -- wpt-commits: ac2c4415f6ea3f0d08a2d19f0e104ce447054db1 wpt-pr: 40160 UltraBlame original commit: e3ed9dae6c2e719eb3ca042485d5493caac92613
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Jun 16, 2023
… to null, a=testonly Automatic update from web-platform-tests Notifications: test that silent defaults to null For whatwg/notifications#194. -- wpt-commits: ac2c4415f6ea3f0d08a2d19f0e104ce447054db1 wpt-pr: 40160 UltraBlame original commit: e3ed9dae6c2e719eb3ca042485d5493caac92613
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #193
(See WHATWG Working Mode: Changes for more details.)
Preview | Diff