Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install Bikeshed on CI #42

Merged
merged 2 commits into from
Jan 11, 2024
Merged

Install Bikeshed on CI #42

merged 2 commits into from
Jan 11, 2024

Conversation

domenic
Copy link
Member

@domenic domenic commented Oct 13, 2022

This helps us move away from depending on the CSSWG API server, which is often broken.

This helps us move away from depending on the CSSWG API server, which is often broken.
@annevk
Copy link
Member

annevk commented Oct 13, 2022

As mentioned on Chat I'm concerned about the wastefulness of this approach. In that we'd end up downloading and installing Bikeshed for each build. As opposed to now where we do a fetch to a service with our input document and use the output document.

@tantek @npdoty reportedly the W3C does this in its tooling. Might be something for the Sustainability CG to look into?

@domenic domenic closed this Mar 24, 2023
@annevk annevk deleted the no-csswg-api branch March 24, 2023 06:24
@domenic domenic restored the no-csswg-api branch January 11, 2024 00:40
@domenic domenic reopened this Jan 11, 2024
@domenic
Copy link
Member Author

domenic commented Jan 11, 2024

Reiterating some private discussions: I don't think the waste is significant here. We're talking ~5 seconds of electricity on both client and server, both of which are probably ~500 watts, so 1K watt-seconds = $0.00018054. That's about 0.568 grams of CO2, whereas sending an email is estimated to take 4 grams of CO2.

Even if my calculations were several orders of magnitude off, I think the human time invested in dealing with these failures is more valuable than even a whole dollar of elecricity/CO2. If you're worried you can eat one less burger (~2.5 kg CO2).

@@ -17,6 +17,7 @@ jobs:
- uses: actions/setup-python@v4
with:
python-version: "3.11"@@build_with_node@@
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to bump this to .12 at the same time?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm scared since Bikeshed is only tested up to 3.11 (per https://speced.github.io/bikeshed/#install-py3 and their GitHub CI file) and I've previously gotten bitten by backward incompatibilities between 3.11 and 3.12 on the web platform tests project.

@annevk
Copy link
Member

annevk commented Jan 11, 2024

And would you mind adding the workflow_dispatch thingie? I can do a deploy across all standards I suppose on Monday. Just before we do the RDs.

@domenic domenic merged commit ff730d6 into main Jan 11, 2024
@domenic domenic deleted the no-csswg-api branch January 11, 2024 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants