Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cancelAlgorithmWrapper does not handle cancellation argument #1273

Closed
mattco98 opened this issue Apr 19, 2023 · 1 comment · Fixed by #1300
Closed

cancelAlgorithmWrapper does not handle cancellation argument #1273

mattco98 opened this issue Apr 19, 2023 · 1 comment · Fixed by #1300

Comments

@mattco98
Copy link

In the "set up" algorithms for ReadableStream which take cancel algorithms and wrap them (here and here), the wrapper is specified as "an algorithm that runs these steps", and then in the steps, says "Let result be the result of running cancelAlgorithm, if cancelAlgorithm was given, or null otherwise". However, in the rest of the spec, the cancel algorithms take a cancellation reason. To me it seems like the wrapper should accept an argument and pass it on. I'd be happy to submit a PR for a fix if this is unintended, but I just wanted to make sure I wasn't missing anything first.

@nidhijaju
Copy link
Contributor

Yes, it's unintentional and I think we have an open issue already: #1241. Please feel free to start a PR to fix it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants