Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Set this.[[associatedReadableByteStreamControll..." #780

Closed
ricea opened this issue Aug 28, 2017 · 1 comment
Closed

"Set this.[[associatedReadableByteStreamControll..." #780

ricea opened this issue Aug 28, 2017 · 1 comment
Assignees
@ricea
Labels
byte streams

Comments

@ricea
Copy link
Collaborator

ricea commented Aug 28, 2017

https://streams.spec.whatwg.org/commit-snapshots/bca1cd313461782cd089dbb79fd721dc9e3890aa#rs-byob-request-constructor

Set this.[[associatedReadableByteStreamController]] to controller

I'm pretty sure we need to check "controller" really is a ReadableByteStreamController here.
@ricea ricea self-assigned this Sep 4, 2017
@ricea
Copy link
Collaborator Author

ricea commented Sep 4, 2017 •
edited

We do need to check, otherwise respond() will try to access fields in controller without checking its type.

An oddity is that is doesn't appear to be necessary to verify that view actually is a view. It might be confusing that respondWithNewView() checks but the constructor doesn't. But in the interests of brevity I plan to leave the unnecessary test out.

@ricea ricea mentioned this issue Sep 4, 2017
Merged
@ricea ricea closed this as completed in #787 Sep 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ricea ricea

Labels
byte streams
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ricea