[META] Integrate with pr-preview

[ricea]

pr-preview would automatically provide diffs of the visible HTML for standard changes. Example output: https://s3.amazonaws.com/pr-preview/whatwg/encoding/ee357f3...6bc288b.html

Unfortunately it doesn't appear to support emu-algify so the integration would be non-trivial. It looks like we'd need a web service to do the translation?

[domenic]

I think @tobie has a mode where it can just use the branch-snapshots stuff that already exists, which gets us 90% of the way there. It doesn't help for external contributor PRs (from forks), though.

[tobie]

What's the issue?

[domenic]

We run a custom build script beyond just Bikeshed, basically.

[tobie]

Oh, right. It's node based?

[domenic]

Yep

[tobie]

It's post-processing, right? On BS output, not BS source, correct?

[domenic]

Indeed!

[tobie]

Give this a spin: https://github.com/tobie/pr-preview#post_processing-optional.

And ping me when you do so I can check the logs. Might completely break, or just work.

[tobie]

Relevant line of code is here: https://github.com/tobie/pr-preview/blob/master/lib/post-processor.js#L9.

[tobie]

Does <emu-alg> appear in the output? If so, @dontcallmedom will have to whitelist it in the HTML differ's tidy.

[ricea]

Yes. <emu-alg> is used in the stylesheet so we need it in the output.

[tobie]

@dontcallmedom already fixed it.

[ricea]

@tobie I tried it approximately 5 minutes ago using the preview feature but it looks like the emu-algify step didn't run.

Pull request containing the config I used is #842.

[tobie]

Config is pulled from the master branch, not the PR branch.

[tobie]

Let me go through the logs, though.

[ricea]

Does this mean that testing via https://tobie.github.io/pr-preview/config.html won't work?

[tobie]

No, it will.

[tobie]

Tracking this config file issue here: tobie/pr-preview#10

[tobie]

@ricea just editing the body of any of your existing PRs (just add an extra line break) should trigger pr-preview for it.

[ricea]

Okay, this happened: https://s3.amazonaws.com/pr-preview/whatwg/streams/20f9c64...5ebb666.html

[ricea]

Ah, the preview works, just not the diff.

[tobie]

Yeah, saw that. Tidy still requires custom-element white-listing for now. @dontcallmedom, can you add <emu-xref> to it. @ricea are there others we missed? (we already added <emu-alg>)

[dontcallmedom]

done @tobie

[tobie]

Thanks a bunch, @dontcallmedom!

[ricea]

<emu-val> is the only other one I found in a quick check.

[tobie]

Same here.

[tobie]

Alright, I need to manually wipe the S3 cache, and then we should be good to give it another try.

[tobie]

Cache wiped. You can give this another go (or alternatively temporarily give me credentials to edit the repo).

[tobie]

And btw, you don't need to push to the PR to trigger a new update, you can just edit the body of the PR on GitHub's web interface.

[ricea]

Okay, looks good: https://s3.amazonaws.com/pr-preview/whatwg/streams/20f9c64...d054b80.html#ts-intro