Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

What are the preconditions for ReadableStreamDefaultControllerError? #920

Closed
ricea opened this issue Apr 4, 2018 · 1 comment
Closed

What are the preconditions for ReadableStreamDefaultControllerError? #920

ricea opened this issue Apr 4, 2018 · 1 comment
Labels
editorial Changes that do not affect how the standard is understood.

Comments

@ricea
Copy link
Collaborator

ricea commented Apr 4, 2018

https://streams.spec.whatwg.org/commit-snapshots/37ace3d5f16cbea7aec4a0c80532c95059994d51/#readable-stream-default-controller-error

says

Specifications ... must ensure they have obeyed the precondition (listed here as an assert).

but there is no assert.
@domenic
Copy link
Member

domenic commented Apr 4, 2018

Yeah, I think this can just be removed; it was probably copied and pasted from nearby abstract ops that did have assert preconditions.

@ricea ricea added the editorial Changes that do not affect how the standard is understood. label May 14, 2018
ricea added a commit to ricea/streams that referenced this issue May 14, 2018
@ricea
Remove preconditions from ReadableStreamDefaultControllerError
8917829 
ReadableStreamDefaultControllerError had a note that specifications should
respect the preconditions (listed as asserts). However, it doesn't have any
asserts. Remove mention of preconditions.

Fixes whatwg#920.
@ricea ricea mentioned this issue May 14, 2018
Merged
domenic pushed a commit that referenced this issue May 14, 2018
@ricea @domenic
Remove preconditions from ReadableStreamDefaultControllerError
d98f243 
ReadableStreamDefaultControllerError had a note that specifications should
respect the preconditions (listed as asserts). However, it doesn't have any
asserts. Remove mention of preconditions.

Fixes #920.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
editorial Changes that do not affect how the standard is understood.
Milestone
No milestone
Development

No branches or pull requests
2 participants
@domenic @ricea