Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

forAuthorCode can be a bit per reader #964

Closed
jorendorff opened this issue Nov 15, 2018 · 5 comments
Closed

forAuthorCode can be a bit per reader #964

jorendorff opened this issue Nov 15, 2018 · 5 comments

Comments

@jorendorff
Copy link

jorendorff commented Nov 15, 2018

Eight different algorithms take a forAuthorCode argument, and it is passed to a lot of places. But if I understand the spec correctly, forAuthorCode is meant to be true iff the stream's current [[reader]] is visible to author code.

So it seems possible to give each reader a [[forAuthorCode]] field instead, and set it to false in AcquireReadableStreamDefaultReader.

This seems more direct, and might even be a nice simplification; if you agree, I'd like to contribute a patch.

@ricea
Copy link
Collaborator

ricea commented Nov 19, 2018

This is a brilliant insight, thank you. If you're willing to create a patch, that would be great. You may need to sign the whatwg CLA (https://participate.whatwg.org/agreement) if you have not done so already.

@domenic
Copy link
Member

domenic commented Nov 19, 2018

In this case @jorendorff would just join https://github.com/mozilla-standards; I think @annevk or @dbaron can add you.

@annevk
Copy link
Member

annevk commented Nov 19, 2018

Done.

@jorendorff
Copy link
Author

Thanks for taking a look! I'll put together a patch next week. (This is Thanksgiving week in the US, so I doubt I'll find time for it.)

@dbaron
Copy link
Member

dbaron commented Nov 19, 2018

I'd note that, as described, @jorendorff needs to make his membership in the organization public.

MattiasBuelens pushed a commit to MattiasBuelens/streams that referenced this issue Feb 9, 2019
This editorial change doesn't affect any observable behavior.

Closes whatwg#964.
ricea pushed a commit that referenced this issue Feb 18, 2019
This editorial change doesn't affect any observable behavior.

Closes #964.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

5 participants