Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add WritableStream.close() #1011

Merged
merged 3 commits into from Nov 3, 2019
Merged

Add WritableStream.close() #1011

merged 3 commits into from Nov 3, 2019

Conversation

MattiasBuelens
Copy link
Collaborator

@MattiasBuelens MattiasBuelens commented Aug 24, 2019 •
edited by pr-preview bot

@ricea
Copy link
Collaborator

ricea commented Aug 27, 2019

Sorry for the delay. It looks great. I haven't been able to find a single thing that needs changing.

Could you land the wpt changes first? Then I will land this.

@MattiasBuelens
Copy link
Collaborator Author

Could you land the wpt changes first? Then I will land this.

I knew I forgot something! 😅

@MattiasBuelens MattiasBuelens mentioned this pull request Aug 27, 2019
Merged
@ricea ricea self-assigned this Sep 13, 2019
@ricea ricea mentioned this pull request Oct 18, 2019
Closed
@MattiasBuelens
Copy link
Collaborator Author

@ricea This PR is still open, although the WPT PR has already landed and the related issue has already been closed. I suppose you simply forgot to merge this PR? 😅

@MattiasBuelens
Copy link
Collaborator Author

Oh right, the deploy failed. 😕

Running deploy for commit: 8d6c0a6f49bf1dd0fa23140cdabaf347e32eef61

Linting the source:
All good

Starting commit snapshot...
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  300k    0   260  100  300k     94   109k  0:00:02  0:00:02 --:--:--  109k
Error running preprocessor, returned code: 1.
LINK ERROR: No 'dfn' refs found for 'transforming' that are marked for export.
<a data-link-type="dfn" data-lt="transforming">transforming</a>
 ✘  Did not generate, due to fatal errorsMakefile:10: recipe for target 'deploy' failed
make: *** [deploy] Error 22
The command "make deploy" exited with 2.

Is this related to #1020? Are we blocked from merging any PRs until those links are fixed?

@MattiasBuelens MattiasBuelens mentioned this pull request Nov 2, 2019
Merged
4 tasks
@MattiasBuelens
Copy link
Collaborator Author

Rebased onto master with no conflicts. The new deploy completed successfully, should be ready to land! 🚀

@domenic domenic merged commit 547428b into whatwg:master Nov 3, 2019
@MattiasBuelens MattiasBuelens deleted the writablestream-close branch November 3, 2019 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ricea ricea

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Should there be a WritableStream.close() method?
3 participants
@MattiasBuelens @ricea @domenic