Set [[disturbed]] synchronously in ReadableStreamPipeTo #1022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set the [[disturbed]] internal slot to true in ReadableStreamPipeTo. This is useful for the Fetch Standard. It is not visible to user code. See whatwg/fetch#959 for the Fetch Standard change that requires this.
Isn't it visible if someone does something like response.body.pipeTo(...)
console.log(response.bodyUsed);? |
My original thought was that this depends on the implementation of pipeTo (ie. whether or not it does the first read synchronously). But I think you can make the difference detectable in any implementation by doing response.body.pipeTo(new WritableStream({}, { highWaterMark: 0 });
console.log(response.bodyUsed);So actually implementations will have to explicitly apply this change. Or maybe this standard is the wrong place to make this change, and it should go in Fetch instead. |
|
Once |
|
Yeah, I am +1 on this change, I just think we may want to accompany it with some web platform tests. |
|
Please see the test at web-platform-tests/wpt#20205. |
domenic
approved these changes
Nov 12, 2019
ricea
added a commit
to ricea/web-platform-tests
that referenced
this pull request
Nov 13, 2019
whatwg/streams#1022 changes pipeTo and pipeThrough to always set the [[disturbed]] slot of the Response's body to true synchronously. This test verifies that behaviour.
ricea
added a commit
to web-platform-tests/wpt
that referenced
this pull request
Nov 13, 2019
whatwg/streams#1022 changes pipeTo and pipeThrough to always set the [[disturbed]] slot of the Response's body to true synchronously. This test verifies that behaviour.
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Nov 29, 2019
…sly, a=testonly Automatic update from web-platform-tests Verify piping disturbs stream synchronously (#20205) whatwg/streams#1022 changes pipeTo and pipeThrough to always set the [[disturbed]] slot of the Response's body to true synchronously. This test verifies that behaviour. -- wpt-commits: 760485a4f652813d1f195ee28042c391cf2fdc02 wpt-pr: 20205
xeonchen
pushed a commit
to xeonchen/gecko
that referenced
this pull request
Nov 29, 2019
…sly, a=testonly Automatic update from web-platform-tests Verify piping disturbs stream synchronously (#20205) whatwg/streams#1022 changes pipeTo and pipeThrough to always set the [[disturbed]] slot of the Response's body to true synchronously. This test verifies that behaviour. -- wpt-commits: 760485a4f652813d1f195ee28042c391cf2fdc02 wpt-pr: 20205
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Nov 30, 2019
…sly, a=testonly Automatic update from web-platform-tests Verify piping disturbs stream synchronously (#20205) whatwg/streams#1022 changes pipeTo and pipeThrough to always set the [[disturbed]] slot of the Response's body to true synchronously. This test verifies that behaviour. -- wpt-commits: 760485a4f652813d1f195ee28042c391cf2fdc02 wpt-pr: 20205 UltraBlame original commit: fcba8dc0552eb96c10b6997d7313972e5177ac93
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Nov 30, 2019
…sly, a=testonly Automatic update from web-platform-tests Verify piping disturbs stream synchronously (#20205) whatwg/streams#1022 changes pipeTo and pipeThrough to always set the [[disturbed]] slot of the Response's body to true synchronously. This test verifies that behaviour. -- wpt-commits: 760485a4f652813d1f195ee28042c391cf2fdc02 wpt-pr: 20205 UltraBlame original commit: fcba8dc0552eb96c10b6997d7313972e5177ac93
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Nov 30, 2019
…sly, a=testonly Automatic update from web-platform-tests Verify piping disturbs stream synchronously (#20205) whatwg/streams#1022 changes pipeTo and pipeThrough to always set the [[disturbed]] slot of the Response's body to true synchronously. This test verifies that behaviour. -- wpt-commits: 760485a4f652813d1f195ee28042c391cf2fdc02 wpt-pr: 20205 UltraBlame original commit: fcba8dc0552eb96c10b6997d7313972e5177ac93
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set the [[disturbed]] internal slot to true in ReadableStreamPipeTo.
This is useful for the Fetch Standard. It is not visible to user code.
See whatwg/fetch#959 for the Fetch Standard
change that requires this.
Also fix two places where the name of the
stateinternal slot wasmistakenly italicised.
Preview | Diff