Always resolve tee's cancel promise after stream closes or errors #1039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MattiasBuelens
force-pushed
the
tee-cancel-bug
branch
from
051e238
to
27022a3
Compare
|
Keeping this as a draft for now. I think that a similar issue could occur when the original stream errors while one branch has started cancelling. I suspect that would also keep the cancel promise pending indefinitely, but I first need to write a test to prove it. |
MattiasBuelens
force-pushed
the
tee-cancel-bug
branch
2 times, most recently
from
89d031b
to
8dc6995
Compare
MattiasBuelens
commented
Jun 12, 2020
MattiasBuelens
changed the title
MattiasBuelens
force-pushed
the
tee-cancel-bug
branch
from
8dc6995
to
4dbc3cb
Compare
MattiasBuelens
force-pushed
the
tee-cancel-bug
branch
from
4dbc3cb
to
763e276
Compare
MattiasBuelens
force-pushed
the
tee-cancel-bug
branch
2 times, most recently
from
79a0dd5
to
32b4f9f
Compare
|
I think this is ready for review. There were some other issues with WPT which also affected this PR, hence the influx of pull requests. Now that those are fixed, this PR is finally green again. 😄 |
domenic
approved these changes
Jul 27, 2020
There was a problem hiding this comment.
This looks good to me. @ricea, I assume Chromium is interested in this fix?
@jorendorff and @youennf, does this sound good to you? I know traditionally we haven't been asking for multi-implementer support for every bugfix to streams, but I think it'd be good for us to get in that habit.
|
Yes, speaking for Google Chrome, we want this fix. |
|
@MattiasBuelens would you mind rebasing? @youennf confirmed he's good with this fix, so we can merge once that's done. |
MattiasBuelens
force-pushed
the
tee-cancel-bug
branch
from
32b4f9f
to
1f9d289
Compare
domenic
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Aug 5, 2020
MattiasBuelens
force-pushed
the
tee-cancel-bug
branch
from
1f9d289
to
5c7ec3a
Compare
|
I filed bugs for WebKit and Gecko, and updated the OP with links to them. For Chromium we'll automatically get a bug filed by the web platform tests importer, and I know @ricea has been pretty good about triaging those. |
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Aug 8, 2020
…tream closes or errors, a=testonly Automatic update from web-platform-tests Test canceling one branch when stream closes or errors Follows whatwg/streams#1039. -- wpt-commits: e5e5e7a10cbb968b31c51ad87ce8a3da62bb1b34 wpt-pr: 24124
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Aug 15, 2020
…tream closes or errors, a=testonly Automatic update from web-platform-tests Test canceling one branch when stream closes or errors Follows whatwg/streams#1039. -- wpt-commits: e5e5e7a10cbb968b31c51ad87ce8a3da62bb1b34 wpt-pr: 24124
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Aug 16, 2020
…tream closes or errors, a=testonly Automatic update from web-platform-tests Test canceling one branch when stream closes or errors Follows whatwg/streams#1039. -- wpt-commits: e5e5e7a10cbb968b31c51ad87ce8a3da62bb1b34 wpt-pr: 24124 UltraBlame original commit: d835b5e68f7177a62bd9782ba6447e786ddac6c9
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Aug 16, 2020
…tream closes or errors, a=testonly Automatic update from web-platform-tests Test canceling one branch when stream closes or errors Follows whatwg/streams#1039. -- wpt-commits: e5e5e7a10cbb968b31c51ad87ce8a3da62bb1b34 wpt-pr: 24124 UltraBlame original commit: f12c531e015c22fc03483b942fdf6e15e9ad686f
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Aug 16, 2020
…tream closes or errors, a=testonly Automatic update from web-platform-tests Test canceling one branch when stream closes or errors Follows whatwg/streams#1039. -- wpt-commits: e5e5e7a10cbb968b31c51ad87ce8a3da62bb1b34 wpt-pr: 24124 UltraBlame original commit: d835b5e68f7177a62bd9782ba6447e786ddac6c9
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Aug 16, 2020
…tream closes or errors, a=testonly Automatic update from web-platform-tests Test canceling one branch when stream closes or errors Follows whatwg/streams#1039. -- wpt-commits: e5e5e7a10cbb968b31c51ad87ce8a3da62bb1b34 wpt-pr: 24124 UltraBlame original commit: f12c531e015c22fc03483b942fdf6e15e9ad686f
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Aug 16, 2020
…tream closes or errors, a=testonly Automatic update from web-platform-tests Test canceling one branch when stream closes or errors Follows whatwg/streams#1039. -- wpt-commits: e5e5e7a10cbb968b31c51ad87ce8a3da62bb1b34 wpt-pr: 24124 UltraBlame original commit: d835b5e68f7177a62bd9782ba6447e786ddac6c9
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Aug 16, 2020
…tream closes or errors, a=testonly Automatic update from web-platform-tests Test canceling one branch when stream closes or errors Follows whatwg/streams#1039. -- wpt-commits: e5e5e7a10cbb968b31c51ad87ce8a3da62bb1b34 wpt-pr: 24124 UltraBlame original commit: f12c531e015c22fc03483b942fdf6e15e9ad686f
blueboxd
pushed a commit
to blueboxd/chromium-legacy
that referenced
this pull request
Aug 17, 2020
Always resolve tee's cancel promise after stream closes or errors. Applies whatwg/streams#1039 to our implementation. BUG=1114014 Change-Id: Ic6d665bd928553ea3a292fe8221f0812d1c613e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358929 Reviewed-by: Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#798520}
sidvishnoi
pushed a commit
to sidvishnoi/gecko-webmonetization
that referenced
this pull request
Sep 23, 2020
…tream closes or errors, a=testonly Automatic update from web-platform-tests Test canceling one branch when stream closes or errors Follows whatwg/streams#1039. -- wpt-commits: e5e5e7a10cbb968b31c51ad87ce8a3da62bb1b34 wpt-pr: 24124
ambroff
pushed a commit
to ambroff/gecko
that referenced
this pull request
Nov 4, 2020
…tream closes or errors, a=testonly Automatic update from web-platform-tests Test canceling one branch when stream closes or errors Follows whatwg/streams#1039. -- wpt-commits: e5e5e7a10cbb968b31c51ad87ce8a3da62bb1b34 wpt-pr: 24124
mjfroman
pushed a commit
to mjfroman/moz-libwebrtc-third-party
that referenced
this pull request
Oct 14, 2022
Always resolve tee's cancel promise after stream closes or errors. Applies whatwg/streams#1039 to our implementation. BUG=1114014 Change-Id: Ic6d665bd928553ea3a292fe8221f0812d1c613e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358929 Reviewed-by: Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#798520} GitOrigin-RevId: 1508bc0bf1fef93eac20c265e5d0c8f0992f14cd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1038.
(See WHATWG Working Mode: Changes for more details.)
Preview | Diff