New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Meta: migrate to GitHub Actions #1041
Conversation
See https://github.com/whatwg/spec-factory for details.
The first commit from this is using whatwg/spec-factory#16. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to work great, thanks! Will let you merge and change the branch protection rules.
I'll change the branch protection rules now, then force push this to see it working, then merge and see test and deploy succeed on master. |
Success: https://streams.spec.whatwg.org/ However, I don't understand why the resulting commit is what it is:
It's not a merge commit (phew) but how did this happen? I thought I used the rebase option to preserve both commits. When I merged, I also briefly saw a message about master having changed and the merge failing, before it succeeds. Seems like something a bit strange happened on the GitHub side here, and the history isn't pretty as a result. |
Hmm. Well, I'd be ok force-pushing to fix things up, unless you think that's likely to backfire. |
OK, I've done that, had to disable branch protection temporarily. I only know of two bad things that can happen:
|
I emailed support@github.com:
|
Part of whatwg/meta#173.