Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix argument order in UnderlyingSinkWriteCallback and TransformerTransformCallback definitions #1054

Merged
merged 2 commits into from Jul 16, 2020
Merged

Fix argument order in UnderlyingSinkWriteCallback and TransformerTransformCallback definitions #1054

merged 2 commits into from Jul 16, 2020

Conversation

MattiasBuelens
Copy link
Collaborator

@MattiasBuelens MattiasBuelens commented Jul 15, 2020 •
edited by pr-preview bot

The WebIDL definition for UnderlyingSinkWriteCallback and TransformerTransformCallback had chunk and controller in the wrong order.

Preview | Diff

@MattiasBuelens MattiasBuelens changed the title Fix argument order in UnderlyingSinkWriteCallback definition Fix argument order in UnderlyingSinkWriteCallback and TransformerTransformCallback definitions Jul 15, 2020
ricea
ricea approved these changes Jul 16, 2020
View reviewed changes
Copy link
Collaborator

@ricea ricea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ricea ricea merged commit 5a4e2d8 into whatwg:master Jul 16, 2020
@MattiasBuelens MattiasBuelens deleted the fix-sink-write-webidl branch July 16, 2020 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ricea ricea ricea approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@MattiasBuelens @ricea