Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editorial: fix extra "the" in controller.error() #1070

Merged
merged 1 commit into from
Aug 25, 2020

Conversation

MattiasBuelens
Copy link
Collaborator

@MattiasBuelens MattiasBuelens commented Aug 23, 2020

As it says on the tin. 😁


Preview | Diff

@MattiasBuelens
Copy link
Collaborator Author

Hmm, looks like the build failed for something unrelated to this PR:

 Error running preprocessor, returned code: 2.
LINK ERROR: No 'idl' refs found for 'MessagePort'.
{{MessagePort}}
make: *** [Makefile:23: deploy] Error 22
 ✘  Did not generate, due to fatal errors
##[error]Process completed with exit code 2.

Did something change in the MessagePort IDL definition?

@ricea
Copy link
Collaborator

ricea commented Aug 24, 2020

lgtm. I will try to track down the cause of the Bikeshed error.

@domenic
Copy link
Member

domenic commented Aug 24, 2020

We're having strange IDL linking errors across the WHATWG spec ecosystem at the moment... speced/bikeshed#1753

@ricea
Copy link
Collaborator

ricea commented Aug 24, 2020

I think if I merge it now it will produce bad output, so I will wait until the IDL linking errors are fixed.

@plinss
Copy link

plinss commented Aug 24, 2020

There was a change to the triggers for Shepherd's IDL detection that broke the HTML spec, reverted. The DB should be updated in a few minutes.

@domenic domenic merged commit f2be831 into whatwg:master Aug 25, 2020
@MattiasBuelens MattiasBuelens deleted the patch-1 branch August 25, 2020 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants