Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Settle reader.[[closedPromise]] before performing close/error steps of read requests #1102

Merged
merged 6 commits into from Feb 8, 2021
Merged

Settle reader.[[closedPromise]] before performing close/error steps of read requests #1102

merged 6 commits into from Feb 8, 2021

Commits on Jan 18, 2021

  1. Settle reader.closed promise before closing/erroring read requests

    @MattiasBuelens
    MattiasBuelens committed Jan 18, 2021
    Configuration menu
    Copy the full SHA
    1541801 View commit details
    Browse the repository at this point in the history

  2. Fix reference implementation of WebIDL promise helpers 

    Calling resolvePromise() or rejectPromise() on a promise that was created
with either promiseResolvedWith() or promiseRejectedWith() would throw
an error, since the expected resolve or reject method did not exist in the
side table.

Resolving or rejecting an already resolved/rejected promise should be a no-op,
so we fix these helpers by returning immediately if we already resolved/rejected
the promise earlier.
    @MattiasBuelens
    MattiasBuelens committed Jan 18, 2021
    Configuration menu
    Copy the full SHA
    d0ed3c1 View commit details
    Browse the repository at this point in the history

  3. Roll WPT

    @MattiasBuelens
    MattiasBuelens committed Jan 18, 2021
    Configuration menu
    Copy the full SHA
    4cea995 View commit details
    Browse the repository at this point in the history

Commits on Feb 7, 2021

  1. Assert that the reference implementation only resolves/rejects promis… 

    …es that are still pending
    @MattiasBuelens
    MattiasBuelens committed Feb 7, 2021
    Configuration menu
    Copy the full SHA
    16bd0b6 View commit details
    Browse the repository at this point in the history

  2. Roll WPT

    @MattiasBuelens
    MattiasBuelens committed Feb 7, 2021
    Configuration menu
    Copy the full SHA
    bc8e299 View commit details
    Browse the repository at this point in the history

Commits on Feb 8, 2021

  1. Roll WPT one last time

    @MattiasBuelens
    MattiasBuelens committed Feb 8, 2021
    Configuration menu
    Copy the full SHA
    dcca4f3 View commit details
    Browse the repository at this point in the history