Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for ReadableStream "owning" type #1271

Open
wants to merge 38 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
38 commits
Select commit Hold shift + click to select a range
9d67644
Add support for a new ReadableStream "owning" type.
youennf Apr 9, 2023
e05ba57
Update index.bs
youennf Apr 14, 2023
6ef5db9
Use _isOwning private slot
youennf Apr 14, 2023
13da733
Ensure transferList is empty for non owning readable streams
youennf Apr 17, 2023
65b6f2a
Update ReadableStreamDefaultController enqueue non normative description
youennf Apr 18, 2023
38d0bc0
Update index.bs
youennf Apr 20, 2023
b8ee345
Update index.bs
youennf Apr 20, 2023
8057ea1
fix StructuredTransferOrClone
youennf Apr 20, 2023
8633ef6
Add Assert to ReadableStreamDefaultControllerEnqueue
youennf Apr 20, 2023
2f924f4
Use Symbol for closing steps
youennf Apr 20, 2023
48ebb43
Update index.bs
youennf Apr 20, 2023
611aae5
Update index.bs
youennf Apr 20, 2023
6d3284f
Update index.bs
youennf Apr 20, 2023
24698dd
Update index.bs
youennf Apr 20, 2023
f5d32b5
Update index.bs
youennf Apr 20, 2023
d4b8b84
Update index.bs
youennf Apr 20, 2023
52a0116
Update index.bs
youennf Apr 20, 2023
21237a6
Update index.bs
youennf Apr 20, 2023
9f0bb24
Update index.bs
youennf Apr 20, 2023
9db7cc2
Update reference-implementation/lib/ReadableStreamDefaultController-i…
youennf Apr 20, 2023
cc6a6b7
Update reference-implementation/lib/abstract-ops/transform-streams.js
youennf Apr 20, 2023
ddbed60
Update reference-implementation/lib/abstract-ops/readable-streams.js
youennf Apr 20, 2023
0ab0d72
Update reference-implementation/lib/abstract-ops/readable-streams.js
youennf Apr 20, 2023
77450a8
Rename closing steps to dispose steps
youennf Apr 20, 2023
46718bb
Update index.bs
youennf May 10, 2023
db7658b
Update index.bs
youennf May 10, 2023
94ebacf
Update index.bs
youennf May 10, 2023
bf7404b
Update index.bs
youennf May 10, 2023
657e85f
Update index.bs
youennf May 10, 2023
a1c6573
Update index.bs
youennf May 10, 2023
4c80708
Update reference-implementation/lib/ReadableStreamDefaultController.w…
youennf May 10, 2023
9146111
Update according review
youennf May 10, 2023
002587a
Reverting WPT module change
youennf Jun 7, 2023
7679251
Update according saschanaz review
youennf Jun 12, 2023
0380d03
Merge branch 'main' into add-support-for-stream-transfer-type
youennf Jun 12, 2023
fa981ae
Move isOwning tab entry
youennf Jun 12, 2023
cbd64e1
Merge branch 'main' into add-support-for-stream-transfer-type
MattiasBuelens May 3, 2024
81411c5
Update Enqueue() call inside ReadableStreamFromIterable
MattiasBuelens May 3, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion index.bs
Original file line number Diff line number Diff line change
Expand Up @@ -2216,7 +2216,7 @@ The following abstract operations operate on {{ReadableStream}} instances at a h
1. Otherwise:
1. Let |value| be ? [$IteratorValue$](|iterResult|).
1. Perform ! [$ReadableStreamDefaultControllerEnqueue$](|stream|.[=ReadableStream/[[controller]]=],
|value|).
|value|, « »).
<!-- TODO (future): If we allow changing the queuing strategy, this Enqueue might throw.
We'll then need to catch the error and close the async iterator. -->
1. Let |cancelAlgorithm| be the following steps, given |reason|:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1921,7 +1921,7 @@ function ReadableStreamFromIterable(asyncIterable) {
ReadableStreamDefaultControllerClose(stream._controller);
} else {
const value = IteratorValue(iterResult);
ReadableStreamDefaultControllerEnqueue(stream._controller, value);
ReadableStreamDefaultControllerEnqueue(stream._controller, value, []);
}
});
}
Expand Down
Loading