Update ReadableByteStream to follow the style rule employed for the main... #283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| 1. Set `this.[[state]]` to `"closed"`. | ||
| 1. Resolve `this.[[closedPromise]]` with **undefined**. | ||
| 1. If **this**@[[state]] is `"closed"`, return a new promise resolved with **undefined**. | ||
| 1. If **this**@[[state]] is `"errored"`, return a new promise rejected with **this**@[[storedError]]`. |
There was a problem hiding this comment.
Leftover backtick at end of line
|
I think this should update to use the underlyingByteSource object, like in #265. Right now the internal slots table is updated but the algorithms are not. There's a bit of merge conflict since I accidentally merged #279. Also let me know if you think we should move this into the main spec. We could either convert it to HTML like the rest of the spec or I could spend some time adding an Ecmarkdown post-processing step so that you don't have to convert as much and the source format remains fairly readable. (Eventually I probably want to use Ecmarkdown for the main spec but it's not a great use of time (or is it?).) |
|
Can close this and roll up into #300. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... spec